From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: Gregory Etelson <getelson@nvidia.com> Cc: dpdk-dev <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>, dpdk stable <stable@dpdk.org>, Ori Kam <orika@nvidia.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>, Bernard Iremonger <bernard.iremonger@intel.com> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after port stop Date: Tue, 24 Nov 2020 06:42:51 -0800 Message-ID: <CACZ4nhvX-=+pHZuSvjB-vM_tJB01xUanF_VJGE8SBP7Zy4BAYg@mail.gmail.com> (raw) In-Reply-To: <20200811061443.8214-1-getelson@nvidia.com> On Mon, Aug 10, 2020 at 11:15 PM Gregory Etelson <getelson@nvidia.com> wrote: > > According to current RTE API, port flow rules must not be kept > after port stop. > > Testpmd did not flush port flow rules after `port stop' command was > called. As the result, after the port was restarted, it showed bogus > flow rules. > > Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") > > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson <getelson@nvidia.com> > Acked-by: Ori Kam <orika@nvidia.com> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > --- > app/test-pmd/testpmd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 7842c3b781..4ba5c41c6e 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2627,6 +2627,9 @@ stop_port(portid_t pid) > RTE_PORT_HANDLING) == 0) > continue; > > + if (port->flow_list) > + port_flow_flush(pi); > + > rte_eth_dev_stop(pi); > > if (rte_atomic16_cmpset(&(port->port_status), > -- > 2.25.1 >
next prev parent reply other threads:[~2020-11-24 14:43 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-11 6:14 [dpdk-stable] " Gregory Etelson 2020-11-24 14:42 ` Ajit Khaparde [this message] 2020-11-26 15:41 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon 2020-11-26 16:43 ` [dpdk-stable] [PATCH v2] app/testpmd: fix testpmd flows left before " Gregory Etelson 2020-11-27 16:01 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko 2020-11-29 6:59 ` Gregory Etelson 2021-01-06 18:07 ` [dpdk-stable] " Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACZ4nhvX-=+pHZuSvjB-vM_tJB01xUanF_VJGE8SBP7Zy4BAYg@mail.gmail.com' \ --to=ajit.khaparde@broadcom.com \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=dev@dpdk.org \ --cc=getelson@nvidia.com \ --cc=matan@nvidia.com \ --cc=orika@nvidia.com \ --cc=rasland@nvidia.com \ --cc=stable@dpdk.org \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git