From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: Gavin Hu <gavin.hu@arm.com> Cc: dev@dpdk.org, nd@arm.com, Thomas Monjalon <thomas@monjalon.net>, Bruce Richardson <bruce.richardson@intel.com>, yong.liu@intel.com, yinan.wang@intel.com, Somnath Kotur <somnath.kotur@broadcom.com>, Honnappa.Nagarahalli@arm.com, ruifeng.wang@arm.com, steve.capper@arm.com, dpdk stable <stable@dpdk.org> Subject: Re: [dpdk-stable] [PATCH v2 3/5] net/bnxt: remove duplicate barrier Date: Mon, 16 Sep 2019 18:55:57 -0700 Message-ID: <CACZ4nhvhi0DZ7BMVi9nd-f7gFFQODkOzg5Jt+u7XE1mFCxPxFQ@mail.gmail.com> (raw) In-Reply-To: <1568633238-47888-4-git-send-email-gavin.hu@arm.com> On Mon, Sep 16, 2019 at 4:27 AM Gavin Hu <gavin.hu@arm.com> wrote: > As there is an inclusive rte_io_wmb within the following rte_write32() > API who rings the doorbell, this makes the above rte_wmb unnecessary and > remove it. > > Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu <gavin.hu@arm.com> > Reviewed-by: Steve Capper <steve.capper@arm.com> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> > Reviewed-by: Phil Yang <phil.yang@arm.com> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > --- > drivers/net/bnxt/bnxt_hwrm.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 9883fb5..1d9fb17 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -115,9 +115,6 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, > void *msg, > data = (uint32_t *)&short_input; > msg_len = sizeof(short_input); > > - /* Sync memory write before updating doorbell */ > - rte_wmb(); > - > max_req_len = BNXT_HWRM_SHORT_REQ_LEN; > } > > -- > 2.7.4 > >
next prev parent reply index Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1568633238-47888-1-git-send-email-gavin.hu@arm.com> 2019-09-06 6:37 ` [dpdk-stable] [PATCH] net/bnxt: fix memory barriers Gavin Hu 2019-09-16 11:27 ` [dpdk-stable] [PATCH v2 3/5] net/bnxt: remove duplicate barrier Gavin Hu 2019-09-17 1:55 ` Ajit Khaparde [this message] 2019-09-16 11:27 ` [dpdk-stable] [PATCH v2 4/5] net/bnxt: replace with cio barrier for doorbell resp Gavin Hu 2019-09-17 1:56 ` Ajit Khaparde 2019-09-16 11:27 ` [dpdk-stable] [PATCH v2 5/5] net/bnxt: enforce io barrier for doorbell command Gavin Hu 2019-09-17 1:55 ` Ajit Khaparde
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACZ4nhvhi0DZ7BMVi9nd-f7gFFQODkOzg5Jt+u7XE1mFCxPxFQ@mail.gmail.com \ --to=ajit.khaparde@broadcom.com \ --cc=Honnappa.Nagarahalli@arm.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=gavin.hu@arm.com \ --cc=nd@arm.com \ --cc=ruifeng.wang@arm.com \ --cc=somnath.kotur@broadcom.com \ --cc=stable@dpdk.org \ --cc=steve.capper@arm.com \ --cc=thomas@monjalon.net \ --cc=yinan.wang@intel.com \ --cc=yong.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches Archives are clonable: git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/ public-inbox