From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C12B5A0C4D for ; Tue, 24 Aug 2021 03:52:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAB8741136; Tue, 24 Aug 2021 03:52:17 +0200 (CEST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id 3CA8F40F35 for ; Tue, 24 Aug 2021 03:52:15 +0200 (CEST) Received: by mail-qk1-f173.google.com with SMTP id b64so7627336qkg.0 for ; Mon, 23 Aug 2021 18:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0dBAT91H5JPrSckiQwykkxQhxiXN9rWmeI0vcE/0Ed4=; b=BHXGVbOuztnrNIovwJplHxRl2AXO5HvBbsSdQNdq+AYd3waBT2OHfxwtnMzF5ECYPq j1PBfC+DUz6NKLrIjuhkVznZyjLqNE+AoZ9ZtXf9RTYMlDvkVpkDaBCDXiPAA6CQ81e0 K/PQlab0NxbnWyAvfG0LtUsjNN/G4tja/1zlc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0dBAT91H5JPrSckiQwykkxQhxiXN9rWmeI0vcE/0Ed4=; b=hfh90mLlPmuL8VhiTfj2CXHBi6DsDJjhwsgISdnZWeEnpXYiUIrxy2uL1/c6XD30cc p7z6IBapaqrDCb+weXnBkkbKcBesNy/39v7AU7B3wzncifgway0suYMV7hwxV0jlMffH uZ9OpGF89Glu0YZnn2CFyo31EdYKlH1vPHRaVE6QN4FqYacC0jsKOespsNDQ2C+Aabkv CsVUg/K325G3OTkUA+YJOuBlKZOTJRjAhF8ROkCaFZV/hqkDy54fvypXIE4d4yZfeUrj CWez73KCMUWBM5H+gLGxoxt2UMmKqv7qdj09z4HJjx17bUSuO7lfxypdjZgAiK+ir3Ac J9kg== X-Gm-Message-State: AOAM533GPrG+MwzDoevg9MQpGOuJsTAIov1FGvcbKMScmnFxWF8Y6Lh/ /XC9KFtyjLIcWVhQS3EtjjhQi5B7yJ//Df4HRsYXkA== X-Google-Smtp-Source: ABdhPJxd1QL3hRQAeeSB35viXhsntZoEhyCl8wGBTQfNnUX2Gjogpue4iUVjGhDXHMFZP6vNAJiKQD/Jo5+/yaE8gZs= X-Received: by 2002:a05:620a:d8e:: with SMTP id q14mr24135212qkl.409.1629769934562; Mon, 23 Aug 2021 18:52:14 -0700 (PDT) MIME-Version: 1.0 References: <20210810060731.30127-1-somnath.kotur@broadcom.com> <20210823154453.403-1-somnath.kotur@broadcom.com> In-Reply-To: <20210823154453.403-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Mon, 23 Aug 2021 18:51:58 -0700 Message-ID: To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit , dpdk stable , Kalesh AP Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000083da605ca44623b" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-stable] [PATCH v4] net/bnxt: fix crash after port stop/start X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" --000000000000083da605ca44623b Content-Type: text/plain; charset="UTF-8" On Mon, Aug 23, 2021 at 8:49 AM Somnath Kotur wrote: > > On chips like Thor, port stop/start sequence could result in a crash > in the application. This is because of false detection of a bad > opaque in the Rx completion and the subsequent kicking-in of the ring > reset code to recover from the condition. > The root cause being that the port stop/start would result in the HW > starting with fresh values, while the driver internal tracker variable > `rx_next_cons` is still pointing to a stale value. > Fix this by resetting rx_next_cons to 0 in bnxt_init_one_rx_ring() > > Fixes: 03c8f2fe111c ("net/bnxt: detect bad opaque in Rx completion") > Cc: stable@dpdk.org > > Signed-off-by: Somnath Kotur > Reviewed-by: Kalesh AP > Reviewed-by: Ajit Khaparde Thanks Ferruh. Patch applied to dpdk-next-net-brcm --000000000000083da605ca44623b--