patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: dev <dev@dpdk.org>
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/nfp: fix check when jumbos and strip CRC
Date: Fri, 17 Nov 2017 21:17:16 +0000	[thread overview]
Message-ID: <CAD+H990JS_CybrtCLd7nL9exepJWCfAX-2c7GZ1JumOZsfs6eA@mail.gmail.com> (raw)
In-Reply-To: <1510943014-8767-1-git-send-email-alejandro.lucero@netronome.com>

Wrong patch.

I have removed it from patchwork.

On Fri, Nov 17, 2017 at 6:23 PM, Alejandro Lucero <
alejandro.lucero@netronome.com> wrote:

> We have two problems here. First the jumbo frame check should not be
> there at all. Then, the configuration should not fail in any case
> related to CRC striping.
>
> Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
>  drivers/net/nfp/nfp_net.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
> index 0501156..99401c5 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -488,13 +488,8 @@ enum nfp_qcp_ptr {
>                 return -EINVAL;
>         }
>
> -       if (rxmode->jumbo_frame)
> -               /* this is handled in rte_eth_dev_configure */
> -
> -       if (rxmode->hw_strip_crc) {
> -               PMD_INIT_LOG(INFO, "strip CRC not supported");
> -               return -EINVAL;
> -       }
> +       if (!rxmode->hw_strip_crc)
> +               PMD_INIT_LOG(INFO, "avoid CRC strip is not supported by
> HW");
>
>         if (rxmode->enable_scatter) {
>                 PMD_INIT_LOG(INFO, "Scatter not supported");
> --
> 1.9.1
>
>

      reply	other threads:[~2017-11-17 21:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-17 18:23 [dpdk-stable] " Alejandro Lucero
2017-11-17 21:17 ` Alejandro Lucero [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD+H990JS_CybrtCLd7nL9exepJWCfAX-2c7GZ1JumOZsfs6eA@mail.gmail.com \
    --to=alejandro.lucero@netronome.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).