From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alejandro.lucero@netronome.com>
Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com
 [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 889CC1C67A
 for <stable@dpdk.org>; Fri, 13 Apr 2018 17:36:26 +0200 (CEST)
Received: by mail-wr0-f196.google.com with SMTP id u46so9202554wrc.11
 for <stable@dpdk.org>; Fri, 13 Apr 2018 08:36:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=netronome-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=x9afrbeH+uShMdcdbwlb+utRUMoXS8fRTp7Cr0SoBFo=;
 b=TeLu49A/QwXIi8+gpW8uT0ZquYX5shoa9QgcX3CmH3ycKEkzrpEYOiaqf2oLFH3Gdc
 pDOysTrxsfGne8HiMrDuSVPeYVr1BeAX+J7aIcCYR+UkGaF/kMVQWCAzvDMlkrQM7SlA
 rj4PDvkxbKsfADGJifqWiaR3YIN0B4XpnuoX4s94HKHvKLHexv0aPV5ts3uz1uGXx/V4
 m185/SQFypIcHaPeGQueXCsuGUbHvCfeqF7D+tFDLH/QowQF08XpfH779U2KPZlYzUpP
 XJ3EFVbLQgqwIva32cFH+TN28mmhk19O+SxKzgITpiJm/2ltCTrplFglw/sWxYNPJ+uw
 kJNg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=x9afrbeH+uShMdcdbwlb+utRUMoXS8fRTp7Cr0SoBFo=;
 b=Mfx23q2RTbmZNjoQnl9L/EtGpRLrW8vDmjQMfNKzP2/NJP+P29lCbJgA6a52z8Mg/f
 qPhgGtN9RSgHQs2DJBBkSxT7FrQZKHRBqAFZKJS1zyoavPAIoTarwOQvJvKjul0+7EZS
 qczf4juLzHgiOVWuJWr6Kk4ATmG/JwHUfY2B9zFgIJjccdabIl919E3ZOuLBrbKwQNWV
 ZdHLjCw4SoEoJmEzf1ZMy6ehIt5j0zRkeoHY6In1E06i63Jibkuvpd2c8UU25X2dpu48
 MEHlIfLIlwme5RGaSWe2hadGiwz5k7o46dFT/zMgLBMxEWBTUpQmS/0CxHyDx+kMtqoz
 sYTQ==
X-Gm-Message-State: ALQs6tCFC0kGGp4/p8Kyb8TOuCSrHAd7efV8OSXNtvNLUf6BEcRkGcTZ
 fcUDiSRmfsRspoARk7y+6QWXf4VUTc9R20XkNt4rKQ==
X-Google-Smtp-Source: AIpwx49ji8AwBpohD8hyvXbXDwgxagbI53HuKK1I6uSUp5GOmFr+Yqk4c37N0x/9J1O0CAMQvFoTANJ1UVxcF3kfzzc=
X-Received: by 10.80.189.130 with SMTP id y2mr20767753edh.138.1523633786383;
 Fri, 13 Apr 2018 08:36:26 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.80.203.69 with HTTP; Fri, 13 Apr 2018 08:36:25 -0700 (PDT)
In-Reply-To: <f7tin8vz1dz.fsf@dhcp-25.97.bos.redhat.com>
References: <20180412222208.11770-1-aconole@redhat.com>
 <CAD+H9916Rjwup_RVkBiLP6yM60n-T+XhdKHYA_q_4pw94XW9Cw@mail.gmail.com>
 <f7tin8vz1dz.fsf@dhcp-25.97.bos.redhat.com>
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Date: Fri, 13 Apr 2018 16:36:25 +0100
Message-ID: <CAD+H990qv8rHymjRr4gcmB1vxgZvHCJ4q=6ctg=27+z1YA7ADQ@mail.gmail.com>
To: Aaron Conole <aconole@redhat.com>
Cc: dev <dev@dpdk.org>, Eelco Chaudron <echaudro@redhat.com>, 
 Pablo Cascon <pablo.cascon@redhat.com>, stable@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-stable] [RFC 0/2] nfp driver fixes
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Apr 2018 15:36:26 -0000

On Fri, Apr 13, 2018 at 2:23 PM, Aaron Conole <aconole@redhat.com> wrote:

> Alejandro Lucero <alejandro.lucero@netronome.com> writes:
>
> > Hi Aaron,
> >
> > Thanks for this patches.
> >
> > I'm afraid these are not applicable for current NFP driver after commit
>
> Okay.
>
> > "net/nfp: add NFP CPP support"
> >
> > which has been accepted in dpdk-net-next.
>
> I think nfp_acquire_process_lock() can be modified as I did in 2/2, but
> I noticed that there's some reliance on various sysfs files (and I think
> you point this out in your response to 2/2 as well) and that may be
> problematic for us with ovs2.8+.  I'll do some more digging.
>

If OVS always relies on VFIO, then it is fine and this patch makes sense.


>
> Thanks Alejandro!
>
> > However, those could be valid for stable versions. I have comments on
> both patches.
>
> Cool.  As I noted, I haven't tested them yet, but once I get time to
> test them I will pull in any feedback and resubmit.  I guess if I do,
> they should really just be for stable fixes?  Not sure how that would
> work.
>
>
Not sure how this needs to be done. Stable versions pull from main branch
just for bug fixing applied patches.
Maybe it is worth to discuss. Adding stable email.


> > On Fri, Apr 13, 2018 at 12:22 AM, Aaron Conole <aconole@redhat.com>
> wrote:
> >
> >  Two fixes, one which is fairly obvious (1/2), the other which may
> >  allow support of non-root users.  These patches are only compile tested
> >  which is why they are submitted as RFC.  After a proper test, will
> >  resubmit them as PATCH (with any suggested / recommended changes).
> >
> >  Aaron Conole (2):
> >    nfp: unlink the appropriate lock file
> >    nfp: allow for non-root user
> >
> >   drivers/net/nfp/nfp_nfpu.c | 25 +++++++++++++++++++++----
> >   1 file changed, 21 insertions(+), 4 deletions(-)
> >
> >  --
> >  2.14.3
>