From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 936D35F29 for ; Fri, 8 Jun 2018 15:50:14 +0200 (CEST) Received: by mail-wm0-f68.google.com with SMTP id v131-v6so3895525wma.1 for ; Fri, 08 Jun 2018 06:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iYXR46RPAIFqQn5RVUOiwwOBCI4QHD3oD30otIaT4P4=; b=UuAJaFJBn1iyKXoyug78GhC3xRaAiuaGLLTbqLKOMwEXUn2Tg6Z0T4Ehc1XITN7hWf c9fvMOZEGcmO6OvMMjPVPNrwZSMpTxmWiQHh+RSkCJN0ajk/Rts4KnQPukC37TalyocK k8mF6w6dTjXNI5EGjubOWL3MyvvYunc21uwJQZ7kNVgTAcNMXbthy6bo5rUWObyyQgcN rHKpmuwK9gFrlewHaVT2FBYMkWpPkEsic4wjtA8H3q/LThJWbr4dYOZcm0z6u5nrE2Pz 9oXD1GdART/YAKmEoPM0Y47DHGjCC0UTeeZNSGZz37YqX3jjsyfbqEtwmPQEhIv5ZBC+ gMfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iYXR46RPAIFqQn5RVUOiwwOBCI4QHD3oD30otIaT4P4=; b=ZJcP51z9XZSxtx/Zefla9KEMl+tMw+t4HTt4IVC2j/P4oUat6ZVKjTU4AbX8OqWGQz 1mcd+A99ppE1beCVycOM9dctk0IyS0UWr5CHs3h9eoAwdRPPyojeNZWxnil8+QGo+Zcl 0xa+u9owXQ7CfpNGNTaWbRnPWYcUirKabrM+SSuw/sEaMv76q1jsgFeMzfEpafkcv6TL b75HJN5MA9JwEK9egePHIPcCC5mpKQv/h+AOxyahq0BF6tOUeBk+1lkqMSEWtbhc0Ekt a3cBEPdKEud0e/d5kw4GL8nqULQpPkBuY5UCmCqFsuJMs2b4xJYCQQSOzZyECPV1OXqm HjFg== X-Gm-Message-State: APt69E2f1vjx+NTMCYBsrcSJT63xBeHMaYwptI1Ji7nByVIOaPTrU6QY 76DO+j4r22u1Eu4HalwM2aRYHOO5t1wNkrxjEFXyOw== X-Google-Smtp-Source: ADUXVKJgDsMorE5iAEh7VRU7Ol+J7zSNr/H2yaWbFCSE7FtF9XiNOV58vES3ACoC+KaqINF8yr08Q7uPTddHaJnr9ss= X-Received: by 2002:a50:8e13:: with SMTP id 19-v6mr7125669edw.101.1528465814153; Fri, 08 Jun 2018 06:50:14 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a50:b197:0:0:0:0:0 with HTTP; Fri, 8 Jun 2018 06:50:13 -0700 (PDT) In-Reply-To: <1528386731-23007-1-git-send-email-alejandro.lucero@netronome.com> References: <1528386731-23007-1-git-send-email-alejandro.lucero@netronome.com> From: Alejandro Lucero Date: Fri, 8 Jun 2018 14:50:13 +0100 Message-ID: To: dev Cc: stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/nfp: fix data offset initialization in TX descriptors X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jun 2018 13:50:14 -0000 Please, ignore this patch. It is not clear yet if we need this. We thought it was fixing a problem but we have doubts now. I have changed the status of the patch to not applicable. thanks On Thu, Jun 7, 2018 at 4:52 PM, Alejandro Lucero < alejandro.lucero@netronome.com> wrote: > The mbuf struct allows to prepend metadata and the NFP TX > descriptors needs to give the data offset to the NIC. > > There is no application using this metadata but it is possible > the PMD itself using it in the future for supporting hardware > offloads like OVS offload. > > Also, this patch fixes a potential issue with the offset bits inside > the TX descriptor not being used nor initialized, but the firmware > checking it and doing the wrong thing if the offset bits contain > garbage. > > Fixes: b812daadad0d ("nfp: add Rx and Tx") > > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > index faad1ee..14f7fc0 100644 > --- a/drivers/net/nfp/nfp_net.c > +++ b/drivers/net/nfp/nfp_net.c > @@ -2245,6 +2245,14 @@ uint32_t nfp_net_txq_full(struct nfp_net_txq *txq) > txds->data_len = txd.data_len; > txds->dma_addr_hi = (dma_addr >> 32) & 0xff; > txds->dma_addr_lo = (dma_addr & 0xffffffff); > + > + /* > + * Prepend metadata? > + * NFP has just support for a 7 bits offset > + */ > + txds->offset_eop = (uint8_t)pkt->data_off & > + PCIE_DESC_TX_OFFSET_MASK; > + > ASSERT(free_descs > 0); > free_descs--; > > -- > 1.9.1 > >