From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22A62A0575 for ; Thu, 5 Mar 2020 21:11:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0736B1BFCD; Thu, 5 Mar 2020 21:11:04 +0100 (CET) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id 99CEF2BB8 for ; Thu, 5 Mar 2020 21:11:01 +0100 (CET) Received: by mail-ot1-f66.google.com with SMTP id x97so138723ota.6 for ; Thu, 05 Mar 2020 12:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ReBDKTW1folYVgVL8D4eYoJ5uGLnrY2w3r0PXXR7CJA=; b=CoiRTS1gOwLL/a7v/zQQ07zIxhX+QOYROlF+mIseCxzNDGGMmLRru0wExfv26lhwUD 7pe3JjQSG1YYnPAKr/ZHME40Im2qmZ52Fv8u77h+w6Dp3DpygRyOesa/gfYQdQzsvpC+ wSVJiIZNwNl0yWV9EFGz0Cgzbu5kNfysO9XAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ReBDKTW1folYVgVL8D4eYoJ5uGLnrY2w3r0PXXR7CJA=; b=b9mmrgeDrjmTRKKfJ28sXW2+HInSQwDZA5KgBVOCOJT1L49ei5j5tlyVL86ekN8ZA5 cYkyVWNpbzZ9Dn8XEHDv0UL8fT0Lf8RFKu0XLcA2y6VMHNvF8Uxtlwe3SQErovr59PHq J3aW7wwCFzAYeIaOrz1VBIbT0D7RofRpWJDvYjzX1rTJd6DuyynAIq/bGlc5PxA/Qv0E PsDczBdDZuzi6io579H2+I/c3XnSFPACx9K9mR2UzrogUjqh2IyiJdTPFkZDV9xA4H0i vBkHEU18yjO7KOyplUE4fm2zch5DG8tXCZ0z8Uu0JngVH7Hn+K3eMXxqD/jdIO2QZEN0 d2XA== X-Gm-Message-State: ANhLgQ1l91C+DAQRCArPfuksugyWz41pNXbNEry/Rp2Aku11yKeN50+I mrlUsFt3zm3LmbIjOD6U6Er3s0nbkReoi6hB1cw0BD4u9jk= X-Google-Smtp-Source: ADFU+vsmViloEOkQ4HMbf53OV9YNg8BtoTHsufg/4jAHE3A9/Hq3yXUx/xBqKIA2GFJLJa3WA7+EI6jjN/1lcm5ib68= X-Received: by 2002:a9d:3ea4:: with SMTP id b33mr191708otc.136.1583439059863; Thu, 05 Mar 2020 12:10:59 -0800 (PST) MIME-Version: 1.0 References: <20200305064500.5634-1-stephen@networkplumber.org> In-Reply-To: <20200305064500.5634-1-stephen@networkplumber.org> From: Lance Richardson Date: Thu, 5 Mar 2020 15:10:48 -0500 Message-ID: To: Stephen Hemminger Cc: dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] net/bnxt: allow configuring vector mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Stephen, On Thu, Mar 5, 2020 at 1:45 AM Stephen Hemminger wrote: > > > Make the configuration use the same as other drivers with > vector mode: ixge, i40e, ... s/ixge/ixgbe/? > > This will also make future support of vector mode on other > architectures possible. > > Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode") > +#error "bnxt: IEEE1588 is incompatiable with vector mode" > +#endif s/incompatiable/incompatible/ This was this approach taken in the initial patch set to add bnxt vector mode support, however based on feedback the current approach was used instead. That discussion can be found here: http://patches.dpdk.org/patch/53683/ If mark support could be treated as a receive offload, it would be possible to choose the non-vector receive handler based on whether mark is enabled. Adding a kvargs option to disable vector mode might be another possibility. Otherwise, a build-time configuration option does seem to be useful. LGTM... with the above: Acked-by: Lance Richardson Regards, Lance