From: Igor Ryzhov <iryzhov@nfware.com>
To: Pavel Ivashchenko <pivashchenko@nfware.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>,
Beilei Xing <beilei.xing@intel.com>,
jia.guo@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix getting eeprom information
Date: Sun, 5 Jul 2020 16:24:29 +0300 [thread overview]
Message-ID: <CAF+s_FwmnQ6epsFJaCxXBpVJF-9-TtNgqn5_Ni4RCuu7zd7uUA@mail.gmail.com> (raw)
In-Reply-To: <20200702123717.2251897-1-pivashchenko@nfware.com>
CCing i40e maintainers.
This is a trivial fix without which getting module EEPROM doesn't work at
all.
On Thu, Jul 2, 2020 at 3:37 PM Pavel Ivashchenko <pivashchenko@nfware.com>
wrote:
> Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c
> b/drivers/net/i40e/i40e_ethdev.c
> index 970a31cb2..5fdfadf7b 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct
> rte_eth_dev *dev,
> }
> status = i40e_aq_get_phy_register(hw,
> I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
> - addr, offset, 1, &value, NULL);
> + addr, 1, offset, &value, NULL);
> if (status)
> return -EIO;
> data[i] = (uint8_t)value;
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2020-07-05 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 12:37 [dpdk-stable] " Pavel Ivashchenko
2020-07-05 13:24 ` Igor Ryzhov [this message]
2020-07-07 2:18 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF+s_FwmnQ6epsFJaCxXBpVJF-9-TtNgqn5_Ni4RCuu7zd7uUA@mail.gmail.com \
--to=iryzhov@nfware.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=pivashchenko@nfware.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).