From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <3chas3@gmail.com> Received: from mail-io0-f174.google.com (mail-io0-f174.google.com [209.85.223.174]) by dpdk.org (Postfix) with ESMTP id B99DD3256 for ; Wed, 5 Sep 2018 11:00:50 +0200 (CEST) Received: by mail-io0-f174.google.com with SMTP id q5-v6so5365368iop.3 for ; Wed, 05 Sep 2018 02:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:sender:from:date:message-id :subject:to:cc; bh=J8T+9Nca91GniygNikH/VOgOWBYtcCJ2s3/uKQ+QbBI=; b=p7iMCb7/43gNwVFKUpRWG6Ro94kTIp9MzJ+0iRVQobHOv/V5nkmWD79MhEoshd8bvb V6Ckuhw/yyBF/VtDlS9/+nu7d9Q/p0ExUXZqsDbbQixnPq1F3PKCvUdUjHPHqiEoamqQ 5w7M2j6V5vutwGHkVLGTB5+qHk1PSK+rJC5+EWrFuPKuo5/3LdICufI6vyOteQdFCs23 wiphyFlduClYouXEdiTGclCq41hVTscoM4fw1b7pDFBoYZywpl4Y23tzEHBR8BdN6hBv 7HS0P8O2UZs0yKO3uvp0Wrmz55cpXqeQbR+IMCSpObCN9gZJCuhU+O+516juGLDeHl9h Qq7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:sender:from :date:message-id:subject:to:cc; bh=J8T+9Nca91GniygNikH/VOgOWBYtcCJ2s3/uKQ+QbBI=; b=JZkyWUf8dzhXiSuhPRSaMrCiYhHXGpGYebB2Z9Uwdxeo+pphbOj6PGKeOTYFBYsPjs C5yRDbTE7r2RUs5W1uaRYxdrV+rALcHjh/HVzdRArudR6YLmv8IgQEF18D2SRgDyEQ+4 oTcwgRnV1YedVX5C5mJIBEAL6i0DOgCalyNCsOFsGfGGIoGdPyK81wgxqUDF+H9XqAAc B3ClqRTo1oOKDBAF20LuHeow6b0Wb/qzLo6g6nHgWbTtXxtb4HyFhk9sLfFHU1wMGK0F Pq3Kpfgdj/5lSdviiC4q9wxnsKPZr0f0ZAhDgMWlLOfd4svwJ0zrcAOzPGrUKI/cdRkY PGSQ== X-Gm-Message-State: APzg51D/PTSEj+jCNlFCXSFnUCqnTydlG7cI7Jf5WRRlDPWiWUrKnKm1 R/ga2s7ZvbKhZ3sUwUekq0URQBie7adL6glxGWQ= X-Google-Smtp-Source: ANB0VdaKETDLISjqIjUkm/Z1IkosNYlM3u6xzPIqx/ZGO9sSYpg1Oi6GEw3OkJUpisUtBzSbqQVHPUP9AhBeR6PkuTE= X-Received: by 2002:a6b:1505:: with SMTP id 5-v6mr25932316iov.56.1536138050069; Wed, 05 Sep 2018 02:00:50 -0700 (PDT) MIME-Version: 1.0 References: <20180905005129.6242-1-3chas3@gmail.com> <2310432A-D93A-4D6A-B3F3-8C885F95D819@mellanox.com> In-Reply-To: <2310432A-D93A-4D6A-B3F3-8C885F95D819@mellanox.com> Sender: chasmosaurus@gmail.com X-Google-Sender-Delegation: chasmosaurus@gmail.com From: Chas Williams <3chas3@gmail.com> Date: Wed, 5 Sep 2018 05:00:38 -0400 X-Google-Sender-Auth: q2MWYXKA8ZMIUP2vr307zPzJHJc Message-ID: To: yskoh@mellanox.com Cc: stable@dpdk.org, mark.rutland@arm.com, Chas Williams Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [PATCH][v4.9.y] Fixes: 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages") X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2018 09:00:51 -0000 On Wed, Sep 5, 2018 at 2:34 AM Yongseok Koh wrote: > > > On Sep 4, 2018, at 5:51 PM, Chas Williams <3chas3@gmail.com> wrote: > > > > From: Chas Williams > > > > Commit 3c226c637b69 ("mm: numa: avoid waiting on freed migrated pages") > > was an incomplete backport of the upstream commit. It is necessary to > > always reset page_nid before attempting any early exit. > > --- > > mm/huge_memory.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 9efe88ef9702..e4c6c3edaf6a 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > Looks like a kernel patch has been sent to DPDK community. ;-) > Well they both start stable... :) Thanks for the heads up! > > Thanks, > Yongseok > > > @@ -1259,12 +1259,12 @@ int do_huge_pmd_numa_page(struct fault_env *fe, > pmd_t pmd) > > > > /* Migration could have started since the pmd_trans_migrating > check */ > > if (!page_locked) { > > + page_nid = -1; > > if (!get_page_unless_zero(page)) > > goto out_unlock; > > spin_unlock(fe->ptl); > > wait_on_page_locked(page); > > put_page(page); > > - page_nid = -1; > > goto out; > > } > > > > -- > > 2.14.4 > > > >