From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B7C3A04FF for ; Tue, 22 Mar 2022 13:23:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4ADA940694; Tue, 22 Mar 2022 13:23:04 +0100 (CET) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by mails.dpdk.org (Postfix) with ESMTP id 805F340694 for ; Tue, 22 Mar 2022 13:23:03 +0100 (CET) Received: by mail-ej1-f45.google.com with SMTP id r22so15738147ejs.11 for ; Tue, 22 Mar 2022 05:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Faha/Ek02nYkdAsEOFdNkQdRjd/BNZadbF4IbGbo7Y0=; b=iTKO2MXk+o4xtRAy7baSC4O6Jz+xl2RGBOcGCQswSfusseCpb9z3oCiDBswqo0JeGx OIJ2J5omusQk8A0axPz1LIzkc7p92Y4wOM5sYcEAQB2lqrsCorcsoMZYnnx+1Ogkp4ZV /IbDHTf8KQSA70tu7MEYpt2qBuQwMpkLGJv6+YLsOuPSsmbdj+aPGu1BMonAofl84yfe rU/+a6I/ulF8YjEby+uZ+mRzIJ5MKRKLGXzHlQkwBOEpQmW3seWpwUi5bNnlhL4z/05d wPnftHBrKaCxoScrdPM3FOh8ioNhoZO6oGQl4S8R3sW4DBzgOTPfev2UQNqIjpaKJ0Ze zUeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Faha/Ek02nYkdAsEOFdNkQdRjd/BNZadbF4IbGbo7Y0=; b=qdFz3FbY6leqr6izXG5h/4VwF/HWKiRV+86/yCBlvPZ7lkKbvIuag2m1zTnFaFGzBG 4odPGbByllOC257HykhZj7tSbZirSpg0DX05wsGK1C93aGQ0wYX72DTJiShmFCJIqeEk Sgyf+ERgD3emkse1sDlwKZ1rUeWi413Y1S3WaxmMGG8csuX9l06PtQBqupaMocRLBZIt +l6RSBm2X/4rYp6Osu9kBR5hfh2bBt5GGiN9248w7ODB4ib7V4rco0lyojiKdB+yaDlO dGT3UwQyjBk3aex3CzIa2eLGNZhTrEiiSO3H0FiRLemf9hey0qVllR04PpJc9Vx7qBy9 0iGQ== X-Gm-Message-State: AOAM531hKPgekmKe5nHbBTm0jJupaMxw2AD3d/0wzP+cYP30JnESM20t /8CzK6dgKMGN3XOtV5I34q5tciRFBSejlMzAFTe3UyF9/Zc= X-Google-Smtp-Source: ABdhPJyFd1Z1hqZ3UmiPPX8WZth3dPnTzsD0EJ8fypvHunSIzkrwLpgIbkZDiX5J5MbM/fuyleolYz9kBNUdlWGVkJk= X-Received: by 2002:a17:906:7947:b0:6da:892f:2503 with SMTP id l7-20020a170906794700b006da892f2503mr24725555ejo.710.1647951783172; Tue, 22 Mar 2022 05:23:03 -0700 (PDT) MIME-Version: 1.0 References: <20220314144228.2475-1-dgr@semihalf.com> In-Reply-To: <20220314144228.2475-1-dgr@semihalf.com> From: =?UTF-8?Q?Dawid_G=C3=B3recki?= Date: Tue, 22 Mar 2022 13:22:52 +0100 Message-ID: Subject: Re: [PATCH 19.11 1/2] net/ena: check memory BAR before initializing LLQ To: christian.ehrhardt@canonical.com Cc: stable@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, On Mon, Mar 14, 2022 at 03:42:34PM +0100, Dawid Gorecki wrote: > [ upstream commit 9ae7a13f8247319f63402107c8304ba57c3f4308 ] > > The ena_com_config_dev_mode() performs many calculations related to LLQ > and then performs an admin queue call to configure LLQ in the device. > > All of the operations performed by ena_com_config_dev_mode() are > unnecessary if membar hasn't been found. Move the dev_mem_base check > before ena_com_config_dev_mode() call. This prevents the unnecessary > operations from being performed. > > Fixes: 2fca2a98c0d1 ("net/ena: support LLQv2") > Cc: stable@dpdk.org > > Signed-off-by: Dawid Gorecki > Reviewed-by: Michal Krawczyk > Reviewed-by: Shai Brandes > --- > drivers/net/ena/ena_ethdev.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c > index 7601d2fa25..dc30370a8f 100644 > --- a/drivers/net/ena/ena_ethdev.c > +++ b/drivers/net/ena/ena_ethdev.c > @@ -1637,6 +1637,13 @@ ena_set_queues_placement_policy(struct ena_adapter *adapter, > return 0; > } > > + if (adapter->dev_mem_base == NULL) { > + PMD_DRV_LOG(ERR, > + "LLQ is advertised as supported, but device doesn't expose mem bar\n"); > + ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; > + return 0; > + } > + > rc = ena_com_config_dev_mode(ena_dev, llq, llq_default_configurations); > if (unlikely(rc)) { > PMD_INIT_LOG(WARNING, "Failed to config dev mode. " > @@ -1649,13 +1656,6 @@ ena_set_queues_placement_policy(struct ena_adapter *adapter, > if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_HOST) > return 0; > > - if (!adapter->dev_mem_base) { > - PMD_DRV_LOG(ERR, "Unable to access LLQ bar resource. " > - "Fallback to host mode policy.\n."); > - ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; > - return 0; > - } > - > ena_dev->mem_bar = adapter->dev_mem_base; > > return 0; > -- > 2.35.1 > I sent the patches last Monday but they didn't make it into the 19.11 branch. I didn't get any response but looking at the mailing list archive it seems that the messages made it to the list. Were there any issues with the patches or were they overlooked? Best regards, Dawid