From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADAA14242B for ; Fri, 20 Jan 2023 08:33:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 877E940150; Fri, 20 Jan 2023 08:33:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CB16E40150 for ; Fri, 20 Jan 2023 08:33:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674200035; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZQBqH6I2p8FyYLD2GEGtxN75cuj18v6bzH3BITH4f0I=; b=Psds8CotNdA0PcZWa2WsDLq5fp6kEEOI/siEV3pNkvwoBNV9AYeZJvf/MOYmFJz+/Cwp3m 3zOInW04xc7cki+fJMdxXIeaN6IvCcoE4xRaLjFYacXz9QbE4hCCcUVCBX9Bs0MK/O8wVF szFvnQ9WgLFgLDpiG57jcdAReO6MuB4= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-665-z8JdvYzsNRWpLfaHf7ovFg-1; Fri, 20 Jan 2023 02:33:54 -0500 X-MC-Unique: z8JdvYzsNRWpLfaHf7ovFg-1 Received: by mail-pj1-f72.google.com with SMTP id om10-20020a17090b3a8a00b002299e350deaso4658711pjb.1 for ; Thu, 19 Jan 2023 23:33:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZQBqH6I2p8FyYLD2GEGtxN75cuj18v6bzH3BITH4f0I=; b=xRY7KDBDprKuQvKlmKAYbdCGd2FkUcS4046qsQU7pO3lcG+zxBI49hQb29PQZLdBCO FLNNnnidb0nSaNW9qzNAHhsF1oTf3YsTH3OGGpzm7jAm0UaQPF0h7plwcX74THJqsdCi NdcCx9v6WlbaJUVgytVWJ1a3q3WrTP/twseOkpF1+GaM4n8tKFW3jCO6Y09M0SQAT1JR 6/LKQ/VJQiNaKOnJaBsR3UBS7N7cWrki8wAdzy0H/qu4Qi2vZElvmEhoFN+aWdu/KLnX baHb/wdK+w6qrJv6MPXy88VpgdnFQ9d/LtBpbCneo125bx/xEXhM7dUYpqKBzDrY8Sp6 C5fg== X-Gm-Message-State: AFqh2kreinmpwntbk9/YqGWSwxGeQIzpyUzzZBKf8BpXymCH1okIHGww TmzKImZuEzXlal4o+6WRUS/muUUQVpvycqDpfsS5KnrrLWYmTKc6n9emQUZMs7/fhIhT5zUr6Xw kxwUWffc63OAtT3ALdYonBC0= X-Received: by 2002:a17:90a:e384:b0:22b:b217:e5ea with SMTP id b4-20020a17090ae38400b0022bb217e5eamr76987pjz.206.1674200033177; Thu, 19 Jan 2023 23:33:53 -0800 (PST) X-Google-Smtp-Source: AMrXdXsUaNPtqAyHGW8DUW1tIqEYUMiEGCS4Drl1Bd+zweW4TvcUBD4aOZ/XBJ/3Ho3vcIPwqana7yky2UIsxgZ3xgA= X-Received: by 2002:a17:90a:e384:b0:22b:b217:e5ea with SMTP id b4-20020a17090ae38400b0022bb217e5eamr76982pjz.206.1674200032941; Thu, 19 Jan 2023 23:33:52 -0800 (PST) MIME-Version: 1.0 References: <20230116105318.19412-1-simei.su@intel.com> In-Reply-To: From: David Marchand Date: Fri, 20 Jan 2023 08:33:41 +0100 Message-ID: Subject: Re: [PATCH] net/i40e: rework maximum frame size configuration To: "Su, Simei" Cc: "Xing, Beilei" , "Zhang, Yuying" , "dev@dpdk.org" , "Zhang, Qi Z" , "Yang, Qiming" , "stable@dpdk.org" , "Zhang, Helin" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Mon, Jan 16, 2023 at 1:15 PM Su, Simei wrote: > > Hi David, > > > -----Original Message----- > > From: David Marchand > > Sent: Monday, January 16, 2023 7:19 PM > > To: Su, Simei > > Cc: Xing, Beilei ; Zhang, Yuying > > ; dev@dpdk.org; Zhang, Qi Z > > ; Yang, Qiming ; > > stable@dpdk.org; Zhang, Helin > > Subject: Re: [PATCH] net/i40e: rework maximum frame size configuration > > > > On Mon, Jan 16, 2023 at 11:54 AM Simei Su wrote: > > > > > > This patch removes unnecessary link status check. > > > > > > Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port > > > level") > > > Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port > > > level") > > > Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Simei Su > > > > Thanks for looking into the issue. > > > > This is rather close to what I had tried [1] along my original report, but it failed > > in the CI. > > Let's see how the validation of your patch goes. > > > > 1: > > https://patchwork.dpdk.org/project/dpdk/patch/20221212143715.29649-1-d > > avid.marchand@redhat.com/ > > > > OK. We will find one environment to see why the unit test failed. Any update? -- David Marchand