From: David Marchand <david.marchand@redhat.com>
To: Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] usertools/pmdinfo: fix usage typos
Date: Wed, 27 Sep 2023 09:56:07 +0200 [thread overview]
Message-ID: <CAJFAV8w1GpLDvZXfd26nmO-FmGznnDrMWuSR2BFcD3zzprT2+Q@mail.gmail.com> (raw)
In-Reply-To: <20230919102012.419201-2-rjarry@redhat.com>
On Tue, Sep 19, 2023 at 12:20 PM Robin Jarry <rjarry@redhat.com> wrote:
>
> The docs and script usages are not consistent.
>
> There is no .devices, .vendor_id nor .device_id fields. Fix usage to the
> correct field names.
>
> Some drivers do not expose any pci_ids, show how to use the []? jq
> operator to avoid spurious errors.
>
> Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script")
> Cc: stable@dpdk.org
>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>
My jq-ryu was not enough, thanks for the fix :-).
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2023-09-27 7:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 10:20 Robin Jarry
2023-09-27 7:56 ` David Marchand [this message]
2023-11-22 23:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8w1GpLDvZXfd26nmO-FmGznnDrMWuSR2BFcD3zzprT2+Q@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).