From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB31F4264F for ; Wed, 27 Sep 2023 09:56:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A35C6402CA; Wed, 27 Sep 2023 09:56:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id F2BC540271 for ; Wed, 27 Sep 2023 09:56:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695801382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D7U0wcfCZi3tBKO4YbFtUryGNyViovkPGtKqyaH8IZk=; b=IXw5kvKLs7DXi75xinyaHrrmoGgWNCWiuHJo/1aQGXiYJCR19P+Z/FpSW3BLQTrEJFQci5 aaaaVvPwrUVk+IG6ieWgiwl7js7bY7YbcYhhPTw2yvipLEMNgT6i00FTTKf1w7m9fVsnsC K32isG2Y6NrF8G1j+etWDKK662spX1s= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-438-IPEpXYkmNdWBFAfHIY8PGA-1; Wed, 27 Sep 2023 03:56:21 -0400 X-MC-Unique: IPEpXYkmNdWBFAfHIY8PGA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5030c5b444eso10083720e87.1 for ; Wed, 27 Sep 2023 00:56:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695801380; x=1696406180; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D7U0wcfCZi3tBKO4YbFtUryGNyViovkPGtKqyaH8IZk=; b=uNkXEEa6Q5JaD97XBeSIUtG194cldHMfFvoMMVOAYwrvTqw4tdXc3CyBYI9a5KoAip gBuHWphWMIUekkT34xMYwZ3Z9DXErGfnrCSHK0hJzmfQvE9+BAAPxvxXr0UUwNKJ7Q/U 82TZgOlwQczesRERUuHLKBgLQfPbxKGkeyCoDJAsX0FAVHD9u4M5zN9YulIygMINGoiG +0IlLm3/pMR27EF2UZJt5vAvK9IpWG0bgsr6yZB5u9sGni5EXnR66w7zIpMcLg5Avs78 KxoQ7OAEmCKlxjv/PiT6waDfMDVPBVlJQQgSbMCDjgZPTp+VspLkgGbc8B95UFHy268n gWQA== X-Gm-Message-State: AOJu0YwuSOYEuHec1+wdXigtXwCDi/HRqGvtcStVVSQYY3iY7XXp3PHk xm3nojCUpQS0y+9EkbK/QvUm6ODPnGNgOghE4dgJSRQ9X5CUygwre4mI4C+mX9TzuZwZXM8typ5 UuzUG8AgrhTxYOBZ9t6ffubE= X-Received: by 2002:a05:6512:36c6:b0:502:a964:84b1 with SMTP id e6-20020a05651236c600b00502a96484b1mr516368lfs.25.1695801380099; Wed, 27 Sep 2023 00:56:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyVkITDu62Nak9RY2BYUsQORisMaWMWpXN+qHpTcdySLpuRFxcBYQVtRpZjvrmb/uIl0z0UvlUVlTlF3DJswQ= X-Received: by 2002:a05:6512:36c6:b0:502:a964:84b1 with SMTP id e6-20020a05651236c600b00502a96484b1mr516352lfs.25.1695801379043; Wed, 27 Sep 2023 00:56:19 -0700 (PDT) MIME-Version: 1.0 References: <20230919102012.419201-2-rjarry@redhat.com> In-Reply-To: <20230919102012.419201-2-rjarry@redhat.com> From: David Marchand Date: Wed, 27 Sep 2023 09:56:07 +0200 Message-ID: Subject: Re: [PATCH] usertools/pmdinfo: fix usage typos To: Robin Jarry Cc: dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Sep 19, 2023 at 12:20=E2=80=AFPM Robin Jarry wr= ote: > > The docs and script usages are not consistent. > > There is no .devices, .vendor_id nor .device_id fields. Fix usage to the > correct field names. > > Some drivers do not expose any pci_ids, show how to use the []? jq > operator to avoid spurious errors. > > Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script") > Cc: stable@dpdk.org > > Signed-off-by: Robin Jarry My jq-ryu was not enough, thanks for the fix :-). Reviewed-by: David Marchand --=20 David Marchand