patches for DPDK stable branches
 help / color / Atom feed
  • * Re: [dpdk-stable] [dpdk-dev] [PATCH] test/service: fix wait for service core
           [not found] <20191127132027.80239-1-harry.van.haaren@intel.com>
           [not found] ` <f7t7e3l5s1a.fsf@dhcp-25.97.bos.redhat.com>
    @ 2019-11-27 21:38 ` " David Marchand
      1 sibling, 0 replies; 5+ messages in thread
    From: David Marchand @ 2019-11-27 21:38 UTC (permalink / raw)
      To: Harry van Haaren; +Cc: dev, Aaron Conole, dpdk stable
    
    On Wed, Nov 27, 2019 at 2:20 PM Harry van Haaren
    <harry.van.haaren@intel.com> wrote:
    >
    > This commit fixes a sporadic failure of the service_autotest
    > unit test, as seen in the DPDK CI. The failure occurs as the main test
    > thread did not wait on the service-thread to return, and allowing it
    > to read a flag before the service was able to write to it.
    >
    > The fix changes the wait API call to specific the service-core ID,
    > and this waits for cores with both ROLE_RTE and ROLE_SERVICE.
    >
    > The rte_eal_mp_wait_lcore() call does not (and should not) wait
    > for service cores, so must not be used to wait on service-cores.
    >
    > Fixes: f038a81e1c56 ("service: add unit tests")
    Cc: stable@dpdk.org
    
    >
    > Reported-by: Aaron Conole <aconole@redhat.com>
    > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
    
    Acked-by: David Marchand <david.marchand@redhat.com>
    
    Before this patch, reproduced the pb in less than 2 minutes with:
    # time (log=/tmp/$$.log; while true; do echo service_autotest |taskset
    -c 0-1 build-gcc-static/app/test/dpdk-test --log-level *:8 -l 0-1
    >$log 2>&1; grep -q 'Test OK' $log || break; done; cat $log; rm -f
    $log)
    
    With the patch, this loop has been running for 40 minutes.
    
    Applied, thanks.
    
    
    --
    David Marchand
    
    
    ^ permalink raw reply	[flat|nested] 5+ messages in thread

  • end of thread, back to index
    
    Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
    -- links below jump to the message on this page --
         [not found] <20191127132027.80239-1-harry.van.haaren@intel.com>
         [not found] ` <f7t7e3l5s1a.fsf@dhcp-25.97.bos.redhat.com>
    2019-11-27 14:16   ` [dpdk-stable] [PATCH] test/service: fix wait for service core Van Haaren, Harry
    2019-11-27 18:11     ` David Marchand
    2019-11-27 19:10       ` Aaron Conole
    2019-11-27 20:11     ` David Marchand
    2019-11-27 21:38 ` [dpdk-stable] [dpdk-dev] " David Marchand
    

    patches for DPDK stable branches
    
    Archives are clonable:
    	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git
    
    	# If you have public-inbox 1.1+ installed, you may
    	# initialize and index your mirror using the following commands:
    	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
    		stable@dpdk.org
    	public-inbox-index stable
    
    
    Newsgroup available over NNTP:
    	nntp://inbox.dpdk.org/inbox.dpdk.stable
    
    
    AGPL code for this site: git clone https://public-inbox.org/ public-inbox