From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4EE60423C3
	for <public@inbox.dpdk.org>; Fri, 13 Jan 2023 14:46:58 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4B7B842E0A;
	Fri, 13 Jan 2023 14:46:58 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mails.dpdk.org (Postfix) with ESMTP id C79A642D53
 for <stable@dpdk.org>; Fri, 13 Jan 2023 14:46:55 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1673617615;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=4+tHxzN4TM7G8nMqPlu1wj2FC8g1zgj4Mes1ppcaqjM=;
 b=XEwkj4QBClvIQnqCFRgHAC4Br55efAKQtidaK49f3rRvlqlfLJCaJH83tP1I3tkD+ElXV9
 ry9fTwl1MicP3jGaIxlAEUBSwQ0W3M6592rGgLts//U+CtPe3PG5+xPt+x7pQy4Mjb+bIy
 UoQ+aQZdMdFcN6B/xuY3O8NO1m1zQww=
Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com
 [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
 us-mta-491-PgrDqPa6NOu3N4ebuYjgxw-1; Fri, 13 Jan 2023 08:46:52 -0500
X-MC-Unique: PgrDqPa6NOu3N4ebuYjgxw-1
Received: by mail-pl1-f197.google.com with SMTP id
 l15-20020a170903244f00b001927c3a0055so14731905pls.6
 for <stable@dpdk.org>; Fri, 13 Jan 2023 05:46:51 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=4+tHxzN4TM7G8nMqPlu1wj2FC8g1zgj4Mes1ppcaqjM=;
 b=mqc4YDt1EuHlvyWO/rDfSQWeBW4mfaH94t6SEOgP392d18HDxOLtQHmyt906CZTRPC
 va3G1G2CEs10xQyTiA1WRqToE7UtR7Th9ZMyeZUG1w+krCNJNjBWcCUYCiDzsqiNYX6W
 fo+xu8Hoa6Vf1XBMSHL+tZZ7WuMXD0lgFSJs2TPNb1eThhSdum6Bnhl1CiePRoqxbGLE
 +zcRVOGIFlONpAkxYaDhSGwc/Dv6+NhkJujjDvt2+nRourbmL1itAOmwiyflsoIpbZDG
 d6vb6SJyAK9ZN/J1az33R8GrQYeN97bPKuzseTnqrFq/Bx+lK0dV/tq414yQbjMwKsq9
 A13w==
X-Gm-Message-State: AFqh2krXeyhQ+jrpRiTJKEI/R1B15yGKf+TNDuaLPSM69LbM8FTO4ZPw
 POB3gyupt2LAOcpEUFBYW+llrauzHq+uu9Jr5yRu7nNIXcg/uvQDiNOxMts9Aw9tnW/pK2YnwIx
 yFmyDnkKu2q9+hKeuOWLTTMQ=
X-Received: by 2002:a17:903:11cf:b0:191:283d:6134 with SMTP id
 q15-20020a17090311cf00b00191283d6134mr5211825plh.106.1673617611106; 
 Fri, 13 Jan 2023 05:46:51 -0800 (PST)
X-Google-Smtp-Source: AMrXdXvsEV9hh98Oxquxc1GDZ23hut4soyXGujA7ex8OL9ZN+Z//mAz/syQOam+uU5MpAFOvIG/9aKmeDw7+BjoorgQ=
X-Received: by 2002:a17:903:11cf:b0:191:283d:6134 with SMTP id
 q15-20020a17090311cf00b00191283d6134mr5211816plh.106.1673617610841; Fri, 13
 Jan 2023 05:46:50 -0800 (PST)
MIME-Version: 1.0
References: <20221212143715.29649-1-david.marchand@redhat.com>
 <20221213091837.87953-1-david.marchand@redhat.com>
 <CAJFAV8wy-ULn8a-bb--i8UBwibYsQ627T5OJhrG3B9hLYqGM-w@mail.gmail.com>
 <CAJFAV8wNKDWmya=ohLWDKaV_Ngy0EaciRwcw8VnCYNsDcT0PtA@mail.gmail.com>
 <CAJFAV8y91Uttpm6Jv=51JF6vuLOEAXuF358uUOb7AuoMFXnPWQ@mail.gmail.com>
 <MN0PR11MB60870D1E6E25837158ED9B42FDC29@MN0PR11MB6087.namprd11.prod.outlook.com>
In-Reply-To: <MN0PR11MB60870D1E6E25837158ED9B42FDC29@MN0PR11MB6087.namprd11.prod.outlook.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 13 Jan 2023 14:46:39 +0100
Message-ID: <CAJFAV8w8BBGY_nFN8boxeqj++OBfq3yiXoQADexPM=Y77v5iwg@mail.gmail.com>
Subject: Re: [PATCH v2] net/i40e: don't check link status on device start
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: "Zhang, Yuying" <yuying.zhang@intel.com>, "Xing,
 Beilei" <beilei.xing@intel.com>, 
 "Mcnamara, John" <john.mcnamara@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 "stable@dpdk.org" <stable@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>,
 Dapeng Yu <dapengx.yu@intel.com>, Wenxuan Wu <wenxuanx.wu@intel.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

On Fri, Jan 13, 2023 at 2:39 PM Zhang, Helin <helin.zhang@intel.com> wrote:
>
>
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Friday, January 13, 2023 9:33 PM
> > To: Zhang, Yuying <yuying.zhang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Mcnamara, John <john.mcnamara@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>;
> > Dapeng Yu <dapengx.yu@intel.com>; Wenxuan Wu
> > <wenxuanx.wu@intel.com>
> > Subject: Re: [PATCH v2] net/i40e: don't check link status on device start
> >
> > Hello i40e maintainers, John,
> >
> > On Mon, Jan 9, 2023 at 10:21 AM David Marchand
> > <david.marchand@redhat.com> wrote:
> > > On Tue, Jan 3, 2023 at 3:02 PM David Marchand
> > <david.marchand@redhat.com> wrote:
> > > > Hi i40e maintainers,
> > > >
> > > > On Tue, Dec 13, 2022 at 10:19 AM David Marchand
> > > > <david.marchand@redhat.com> wrote:
> > > > >
> > > > > The mentioned changes broke existing applications when the link
> > > > > status of i40e ports is down at the time the port is started.
> > > > > Revert those changes, the original issue will need a different fix.
> Hi David
>
> Does it break all the application or just a specific application?

I don't see how it would not affect all applications seeing how the
original patch is dumb.

> We may need to understand the issue you met, and try to fix it later.

Just unplug the cable or fake a link down on your i40e port, start
your application or port, then plug the cable back.
The max frame size will never get applied to hw.


-- 
David Marchand