From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3996143CA1 for ; Wed, 13 Mar 2024 15:13:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B02942DE0; Wed, 13 Mar 2024 15:13:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7BB5C402B8 for ; Wed, 13 Mar 2024 15:13:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710339185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rof+zzyDDtJdAlR33Ln3zKtqR/0OLRkLtVu7GCWNHXo=; b=dy7/xeMotrdRtgX5YBB1GKyIdmH4OYAyJs6v0C9mfQtcnKTGZXopf1fYl5uqEkpekBNeYW KOto5DWn0212tJU2a+yjkihELGSecJfSZmHTehNKsBXjWbhhsscNKefcdvgerTDmyO3N6j ZWHQ9ZER1p6dvpbCaQ+PITnRJ2hhjAg= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-657-Jf0JEgh3MyKguQ8nYNWqNA-1; Wed, 13 Mar 2024 10:13:03 -0400 X-MC-Unique: Jf0JEgh3MyKguQ8nYNWqNA-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-513cbc95912so282380e87.0 for ; Wed, 13 Mar 2024 07:13:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710339182; x=1710943982; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rof+zzyDDtJdAlR33Ln3zKtqR/0OLRkLtVu7GCWNHXo=; b=qvrJoiM8mqLeatKl2h6TAll9srRIP8CpTY2Tc6FfvY2s2BY+dt8yJTEOxVdaE1ofrb gaI7A/mIlgpPnyjH4x/Ev0pBx9pvniXXjuDsop5HtEZ4WIyFp9nJ6Ra2KIkCnmTulgGm 2uRhSvq/UJc6xvK79Uvi8cWUDn5oxvPdFCg0mPvkkfHTfwhwTomfXh430C6bTm6xkiaZ q4PIhwCfashKSCXZbl6GqGVJr03hJDf7fY0ul9pmWFdZYn3LWD9jz/bXv8brV8TdRoI9 Px2fJlQVmJ5gyT5TblOAqkfcR423IstRb88G+79BdVwnPqkOOxXC0Q/vb0p2HkOPgUm0 6QKQ== X-Forwarded-Encrypted: i=1; AJvYcCWqfgyJgd18e9Sdg+YWLQ3HiGxKF6f6J5redVWg9LtmtEK4Mx+08S2LuVSaRzPSyaywQmsxYkbZI0tGXNCi/Ls= X-Gm-Message-State: AOJu0Yyh97C7qt6DJMw3cQJoArH0VQrWmiLy3zW0enXm3AS/I0cwuHZI WW/5Oc0vD/k8/0IYM0bqA/5CpvCpUv5z55phlPeCNv33BNB3zhozUDPat2E5QbJ4DfQh/EIHtSq brrtm76QZxH7Eee+sUqt7U9Mm80IA0SyH78GJOfdIfvnmPFNFwuM3MvtUZb5BZxczFWRO25Fyzw KVmUwEDgIa3lKRpPdkqr8= X-Received: by 2002:ac2:58c3:0:b0:513:a766:4643 with SMTP id u3-20020ac258c3000000b00513a7664643mr3294617lfo.11.1710339182165; Wed, 13 Mar 2024 07:13:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnGfCh6XoqSwcm6ctlg6loCdQeOy3VvfXXNyqKHhO1M2MG+0B1Df+5VdPlMqszZQe7fBVxNSfQYdJhciGz2XM= X-Received: by 2002:ac2:58c3:0:b0:513:a766:4643 with SMTP id u3-20020ac258c3000000b00513a7664643mr3294578lfo.11.1710339181165; Wed, 13 Mar 2024 07:13:01 -0700 (PDT) MIME-Version: 1.0 References: <20240313125932.1878279-1-maxime.coquelin@redhat.com> <20240313125932.1878279-2-maxime.coquelin@redhat.com> In-Reply-To: <20240313125932.1878279-2-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 13 Mar 2024 15:12:49 +0100 Message-ID: Subject: Re: [PATCH v2 1/2] net/virtio: fix vDPA device init advertising control queue To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com, schalla@marvell.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Mar 13, 2024 at 1:59=E2=80=AFPM Maxime Coquelin wrote: > > If the vDPA device advertises control queue support, but > the user neither passes "cq=3D1" as devarg nor requests > multiple queues, the initialization fails because the > driver tries to setup the control queue without negotiating > related feature. > > This patch enables the control queue at driver level as > soon as the device claims to support it, and not only when > multiple queue pairs are requested. Also, enable the > control queue event if multiqueue feature has not been > negotiated and device start time, and disable it at device > stop time. > > Fixes: b277308e8868 ("net/virtio-user: advertise control VQ support with = vDPA") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin Reviewed-by: David Marchand --=20 David Marchand