From: David Marchand <david.marchand@redhat.com>
To: "Zhang, Tianfei" <tianfei.zhang@intel.com>,
"Hussin, Mohamad Noor Alim" <mohamad.noor.alim.hussin@intel.com>
Cc: "Xu, Rosen" <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Huang, Wei" <wei.huang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] ifpga/base/meson: fix looking for librt
Date: Thu, 15 Jul 2021 10:00:19 +0200 [thread overview]
Message-ID: <CAJFAV8wB=gtzvgTsEhdLfUiFxwgK+LFG5+pM18kAvPjQ5LCCxw@mail.gmail.com> (raw)
In-Reply-To: <BN9PR11MB54837BF4710F18ACC16F4659E3139@BN9PR11MB5483.namprd11.prod.outlook.com>
Hello,
On Wed, Jul 14, 2021 at 5:40 AM Zhang, Tianfei <tianfei.zhang@intel.com> wrote:
>
> >
> > Hi Tianfei,
> >
> > To reproduce this, assume using Ubuntu 20.04.
> > 1. Install libfdt (It will include ifpga driver from drivers/raw/ifpga/base)
> > $ sudo apt-get install libfdt-dev
> > 2. configure DPDK library
> > $ meson build
> > 3. check libdpdk.pc file in build/meson-private/libdpdk.pc. It will include path
> > to librt.so without this patch.
>
> I have checked the libdpdk.pc and got the different between with and without this patch.
> Without this patch, there are a full path for librt.so in libdpdk.pc. With this patch, it provide "-lrt" in libdpdk.pc.
>
> This patch looks good for me.
>
> Acked-by: Tianfei Zhang <Tianfei.zhang@intel.com>
I can't find the original mail to dev@dpdk.org and patchwork did not help.
Please, can you resubmit this patch?
Also copy Bruce as this touches a meson subtlety I was not aware of,
and he should probably have a look.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2021-07-15 8:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210630092613.70647-1-mohamad.noor.alim.hussin@intel.com>
2021-06-30 10:02 ` [dpdk-stable] " Xu, Rosen
2021-07-01 13:18 ` Zhang, Tianfei
2021-07-02 1:46 ` Hussin, Mohamad Noor Alim
2021-07-14 3:40 ` Zhang, Tianfei
2021-07-15 8:00 ` David Marchand [this message]
2021-07-15 8:11 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2021-07-22 8:16 ` [dpdk-stable] " mohamad.noor.alim.hussin
2021-08-30 9:29 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2021-09-28 4:36 ` [dpdk-stable] [PATCH v3] " mohamad.noor.alim.hussin
2021-10-06 14:14 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wB=gtzvgTsEhdLfUiFxwgK+LFG5+pM18kAvPjQ5LCCxw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mohamad.noor.alim.hussin@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).