From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C3A2A04C2 for ; Fri, 15 Nov 2019 14:31:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E14AD2F42; Fri, 15 Nov 2019 14:31:37 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 974E12C08 for ; Fri, 15 Nov 2019 14:31:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573824695; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bV2txTf7TM4qS6qj5xTXNA1uS2aweQDuTLpSI1Cp+9U=; b=J1u0jEtRJd4sEI4+2UXwmQzF25a/ac9TGVBP2s6VLwkOoMozOvAB6bEQ8uCBTJ5JVls0Un cw3+rd6sY2arrpL30pS4ui65ErKLlpW7PoE8hwPBChf5sprKEG2OQsiM6dLgxTy70RJgJ4 PHAYLGsj2GOGBwrH5o9sMv/vtsw6q7I= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-nh1WsMxNP8SMw8uHgX7wmA-1; Fri, 15 Nov 2019 08:31:31 -0500 Received: by mail-ua1-f70.google.com with SMTP id r39so2280397uad.3 for ; Fri, 15 Nov 2019 05:31:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TTTbMa8HR07jlBm8mxDSrlNZ2M+h4ALrXbdwV2zIx5E=; b=bsqBrawVrdWgkDgMi4d9/W9KxcF1m7nlBkU3pdQ7efAAsColRe6A1HqkMckAPXJxrN VieTrwch8GeMWNyuaEGTd9mJlVfkGKZYDOsGZ4Zs3+eIzZfz7Fc7Z/a+fh5cmNGlURWh 0pENoQS20UD3a9x1Go5Rcht317Kaclx2cM2EuSG6OcUSCz0unCVgT6O6vek8bXa0zY66 r8UTMcU8TR8z2toNYU2CdWpq+02qBvBA6quxHRGvIOkIie1TfcBL8Z4W82VmNZH5b1D/ CY+oOoSfnBF6vc8NcbhW9sRFN5hoKbW1zvDo80ZP03yL3I41W6braYIIMk0uH4L4pPVz 0Muw== X-Gm-Message-State: APjAAAX6LJaXSkyoSDFXETMtz9nu38Zt/v8NOild36OQiOoHE7ckKWrj yC4epQPNDIYDYtMvHiV8+0B8BmNiVukjC7JE3qvt6lCv0sKUlJgtCli9KP/sxZ9TT/JDHKsnciI r5dIBHYkuomUnidpRHHTQ/DI= X-Received: by 2002:a1f:60ce:: with SMTP id u197mr3035130vkb.80.1573824690952; Fri, 15 Nov 2019 05:31:30 -0800 (PST) X-Google-Smtp-Source: APXvYqxeLjWyYKF5XNe9KtmzAxwVZonKWD4ep76P+C4tWx6v0XND3+mfiHHPNw2SbIWkR1Wbu57CkYRvUhutBcDHrms= X-Received: by 2002:a1f:60ce:: with SMTP id u197mr3035095vkb.80.1573824690433; Fri, 15 Nov 2019 05:31:30 -0800 (PST) MIME-Version: 1.0 References: <1573643008-8216-1-git-send-email-wangzk320@163.com> <36d4ff71-bce4-6b69-7110-c4f6b9bfa51d@redhat.com> <20191115041520.GA22736@___> In-Reply-To: <20191115041520.GA22736@___> From: David Marchand Date: Fri, 15 Nov 2019 14:31:19 +0100 Message-ID: To: Zhike Wang Cc: Maxime Coquelin , dev , dpdk stable , security@dpdk.org, wangzhike@jd.com, Tiwei Bie X-MC-Unique: nh1WsMxNP8SMw8uHgX7wmA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix vring message handling broken in some case X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Nov 15, 2019 at 5:14 AM Tiwei Bie wrote: > > On Thu, Nov 14, 2019 at 09:52:30AM +0100, Maxime Coquelin wrote: > > Maybe change the title to something like: > > > > vhost: fix vring requests validation broken if no FD in payload For the title, aligning to backport patches: "vhost: fix vring requests validation broken if no FD" > > > > On 11/13/19 12:03 PM, Zhike Wang wrote: > > > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0, > > > so validate_msg_fds() will return error. In this case, > > > the negotiation of vring message between vhost user front end and > > > back end would fail, and as a result, vhost user link could NOT be up= . > > > > > > How to reproduce: > > > 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk. > > > 2.Notice that inside ovs there are endless logs regarding failure to > > > handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up. > > > > > > Fixes: bf47225 ("vhost: fix possible denial of service by leaking FDs= ") Fixes: bf472259dde6 ("vhost: fix possible denial of service by leaking FDs"= ) Cc: stable@dpdk.org > > > Signed-off-by: Zhike Wang > > > --- > > > lib/librte_vhost/vhost_user.c | 13 ++++++++++--- > > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > > > > otherwise: > > > > Reviewed-by: Maxime Coquelin > > > > The title can be changed while applying if you agree with it, no need t= o > > send v3. > > > > I'll take care of the different backports. > > > > Reviewed-by: Tiwei Bie Applied, thanks. --=20 David Marchand