From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 406F846DAF for ; Wed, 27 Aug 2025 11:16:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 240AA402EA; Wed, 27 Aug 2025 11:16:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4ECE3402EA for ; Wed, 27 Aug 2025 11:16:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756286174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/P9BFVMNt2PPKuITUTRJU6WMNTdOGgokvEVZxO7Zzyo=; b=Qo3uaUmFf5rRywoPE1deWs7+lAxO/4ZBwFdmJa+WnbsUWw4aeCrcO/F3z/EW6qXNZsPO49 s3NSOjrj+4s+r+ZnUyKDa/HjKRTpdSv1+QL1Ytq+AcJGVwvuUqB51+bL+cjpRzZuYjo2QY YoW9pEI6Zv0zOItgZ10tXOcnjHZ/i4Y= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-0L3B88Z2OgmMcLda77oUZQ-1; Wed, 27 Aug 2025 05:16:11 -0400 X-MC-Unique: 0L3B88Z2OgmMcLda77oUZQ-1 X-Mimecast-MFC-AGG-ID: 0L3B88Z2OgmMcLda77oUZQ_1756286170 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-3368f6247a9so5665711fa.3 for ; Wed, 27 Aug 2025 02:16:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756286170; x=1756890970; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/P9BFVMNt2PPKuITUTRJU6WMNTdOGgokvEVZxO7Zzyo=; b=tT76DBw4XHAfTFc2jNa7GFig0+VOQSoAqmbqgGqB9kBts5oJGU2TSVZRkjmnOK6Sxq Aqi9iZ5kQYQURa/9ZS8aYtQK8x87GIY5DBIosX8OGa1Oyg0VwVao9MJ/NP5zdj9S3iEE wfQ0k4sqUJrJLPVBr834078+rMV2mVtjdy+6gcR8iPwVZFC7IBIqQYiJVXePqcD67Yqx 8FJA/0uCXtuXQT/UkQK0B9a/yZLJRwCUeWik9hAmsjsDLmtEyqm23Dlmqc55bkvO30yZ sNDxXTnp2sZq5ayzWjO33t3l4l31a+xuPeaEl6xg2knelVomXGLTnuyXKkOs4WJ7/BxH HleA== X-Forwarded-Encrypted: i=1; AJvYcCVJc91IbcXA0+ORWBmxfIxnBtrTEcsgfw7q1BoPjBBKe+y9I07LUcZx+57gYjsTp3XLAPWPm1c=@dpdk.org X-Gm-Message-State: AOJu0YxgsL3qyukq6y1JZSRXymfa8x8CrIQ2wt1kjy6PSy83XiZydCkl 673zzeenrEX/tLS9AplDLryQXxdtd7ICA8irrjwMR1P7xm895GjXM4RRdaeMVNRbQPmAwzlivvV ApajS3vVh0ZLEOZUcElDdSqhHp0xnZUkuRHHvwcVNtpfTFFyILube2cNx1PWvDDwNzr0luyLgnE WeXBYgUFrIisgCfoPrV1NmL3w= X-Gm-Gg: ASbGncs59PmdT9V6uD6cA8DE4ap55CaWgkLDiqSW8xYYjnES4Wlz3RULG0+m1Hjxnje 1uviKHHNiGQiYhokYnzfBSOSaHN3YCZI8xXJ+h2QDzdbL0lZgywIkRK8p/neyXSfGFgAR09dOWf 8CVQVWCWeiD3HnXvhfsRYgYfI= X-Received: by 2002:a05:651c:20cc:20b0:32b:78ce:be8e with SMTP id 38308e7fff4ca-33650faa9c1mr37013481fa.32.1756286169707; Wed, 27 Aug 2025 02:16:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/aSiITayBg93Weisj4ctj5oUxfRuT+mQWSqNUv9o2V0nBbyL0PnYQBOiDbUBvpWEtzyGJ6zRonZJ/ltFSwYo= X-Received: by 2002:a05:651c:20cc:20b0:32b:78ce:be8e with SMTP id 38308e7fff4ca-33650faa9c1mr37013341fa.32.1756286169279; Wed, 27 Aug 2025 02:16:09 -0700 (PDT) MIME-Version: 1.0 References: <20250820084521.1088620-1-dsosnowski@nvidia.com> In-Reply-To: <20250820084521.1088620-1-dsosnowski@nvidia.com> From: David Marchand Date: Wed, 27 Aug 2025 11:15:57 +0200 X-Gm-Features: Ac12FXzxEaqHGmt6JjXf1jFlhKvGHdEhz2jH8BokbP0oKYW3F5zMo3YvKP8u-QI Message-ID: Subject: Re: [PATCH] net/mlx5: fix matcher flags in counter offset detection To: Dariusz Sosnowski , Andre Muezerie Cc: Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , dev@dpdk.org, Raslan Darawsheh , stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ewf1ihR4CFaOwkudElXHAjQ0i3tjpeQhW9HBZwJfmxY_1756286170 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, 20 Aug 2025 at 10:47, Dariusz Sosnowski wrote: > > This patch fixes a bug in > mlx5_flow_dv_discover_counter_offset_support() > uncovered by a warning reported by MSVC: > > ../drivers/net/mlx5/mlx5_flow_dv.c(19636): warning C5287: > operands are different enum types 'ibv_flow_attr_type' and > 'ibv_flow_flags'; > use an explicit cast to silence this warning > > IBV_FLOW_ATTR_FLAGS_EGRESS was incorrectly passed in to > type field of mlx5dv_flow_matcher_attr struct, > instead of flags field. > As a result counter offset support discovery returned a false positive > result on application with old rdma-core. > > Bugzilla ID: 1758 > Fixes: 4fd5e1484887 ("net/mlx5: fix counter offset detection") > Cc: suanmingm@nvidia.com > Cc: stable@dpdk.org > > Reported-by: Andre Muezerie > Signed-off-by: Dariusz Sosnowski I did not test the patch, but on the principle this lgtm. Andre, can you confirm it solves the build warning you were seeing with MSVC? -- David Marchand