From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F205148A09 for ; Thu, 30 Oct 2025 09:54:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E65F2402ED; Thu, 30 Oct 2025 09:54:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DA69940297 for ; Thu, 30 Oct 2025 09:54:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761814455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jBI4x5BReo8nvO8FR20VWTZFHranNbvcsFky7HuKjBo=; b=R/9qXPDCf1mFedoZopfVB8zLLapI6D0CpBdHq+q/JdtAEaxwwe55ISrw6PEhc5GiYpo8XP MBtRUxejPuIwcj8J3t3YRYhN2IZnl1/qjEAiGcHWASemmvyEvD8a3DVm0Bivt8p0rxm2Pj 57WzHH6dZTZNEF5lIH8LAUe5Y9cjGHI= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-ZN1r2KY9PGaoFVfyVDRpow-1; Thu, 30 Oct 2025 04:54:13 -0400 X-MC-Unique: ZN1r2KY9PGaoFVfyVDRpow-1 X-Mimecast-MFC-AGG-ID: ZN1r2KY9PGaoFVfyVDRpow_1761814452 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-36d99707249so3216641fa.3 for ; Thu, 30 Oct 2025 01:54:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761814452; x=1762419252; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jBI4x5BReo8nvO8FR20VWTZFHranNbvcsFky7HuKjBo=; b=MgrFbiIVQAWNv+ZIap2TSoB/yVqxanrIAP8Im/ReikOt90YKG0cOdvUPSMNo0qrj3m YXPt/kXxyJD2GohMLePWbzqbbv/JSTGSuzoMby5ev8gBPQlZtKAe7Om1yfPFzjCd/Bz0 42SqY92oJ1t/fyl5z4DPGvWSe+q5a3/Aa7cl3tme8t0LAjF5l7+HFQPSfn0ahDxhIofH +pVWd0fW4L1Xf/+oEUCZH/LHQAIQKwF7Uz6MT96l1a4o+JUyMePJNRVe7lbc/MsMqRkb 98HVLY8Zw6DW5VnCQHV08NtSx+vf1B7O7XKpwbeX4n2IeRuVdaZ9+jg2OwxOP3wVrXFa qIlQ== X-Forwarded-Encrypted: i=1; AJvYcCXCPdTT5a2o2qbf3Ef/LG21Wt2RRHgXkSrbtCgmewWNz7bhzYyVCCFiGcd30PsPxV1W4AqPxUA=@dpdk.org X-Gm-Message-State: AOJu0YxUb1IeETXcvzPDnbOGXjfn+hQJpjYDCrPlyPQKDTrukOA/dMc/ qoCfVL0YQiB3LEWMvwAGDviE+xmtrvWem0Pey4j4YZzhSChSOoUoyyHGzV0fDbibXdIIK5CTND3 w1oWPuy6XQZ3RNQe+zqFMpgXUMcDWl84C9ATc1HE+wKkdilMsG/kEWTJpas1TTehHujk4WlzjbE juhyGj1LEfZhj+3LOBG9npEcY= X-Gm-Gg: ASbGncurwhjx5uUhhNj/qUSL4DNVWhynBRwI/hXxB+DeHvizHajPJTBpzFh/SVlLrW8 QtghSKisrgedwJ8wKA5PSPYyo+fCMjObiy5mwskTLZOiKO5ZzCSowYrIzvdras5qNyYFkB/1xMo LAS3PqGyT0+gMd0STBkoPTzpZAj9T7v2iw1kGmgZoTK0voBjyEemaxoI/Qaw== X-Received: by 2002:a2e:b894:0:b0:36b:ce19:d853 with SMTP id 38308e7fff4ca-37a05378dcamr19051871fa.45.1761814452107; Thu, 30 Oct 2025 01:54:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGs3guIQQw3/PtVMFdLy6CtIQAxPsvk+eZ+/9Pgaxb2Il21mn7PNBYhX/oQ3zYNSRJBt/mQn1umDtBNx1yy7nk= X-Received: by 2002:a2e:b894:0:b0:36b:ce19:d853 with SMTP id 38308e7fff4ca-37a05378dcamr19051811fa.45.1761814451666; Thu, 30 Oct 2025 01:54:11 -0700 (PDT) MIME-Version: 1.0 References: <7e4985db2bbf29515f8cd6a4ab510d71f8a636a3.1761299581.git.anatoly.burakov@intel.com> <05ecc81aefbbe2073416c0e78aed926ec9ad54b5.1761299581.git.anatoly.burakov@intel.com> In-Reply-To: <05ecc81aefbbe2073416c0e78aed926ec9ad54b5.1761299581.git.anatoly.burakov@intel.com> From: David Marchand Date: Thu, 30 Oct 2025 09:54:00 +0100 X-Gm-Features: AWmQ_bl4HBsjBR5ubryEsRIyYLzvaeW56Tjv6c82XY3Jgq6ozauGk8_EpkMijHM Message-ID: Subject: Re: [PATCH v1 2/2] bus/cdx: fix incorrect device release on error To: Nipun Gupta , Nikhil Agarwal Cc: dev@dpdk.org, Anatoly Burakov , Ferruh Yigit , stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pKZhHiYLxCurg8Js6Y6UWGoomd_N2VTtW9fgu45ThUo_1761814452 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 24 Oct 2025 at 11:53, Anatoly Burakov wrote: > > The variable cdx_addr is a stack-allocated zero-initialized char array, but > it is never used anywhere except in an error handler to stand it as a > device bus address for a VFIO device release call. This is incorrect, as it > should have been actual device address, so fix the code to reflect that. > > Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus") > Cc: nipun.gupta@amd.com > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Reviews on this series please. -- David Marchand