From: David Marchand <david.marchand@redhat.com>
To: wangyunjian <wangyunjian@huawei.com>
Cc: dev <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
xudingke <xudingke@huawei.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] vfio: remove unused variable
Date: Mon, 29 Jun 2020 11:44:29 +0200 [thread overview]
Message-ID: <CAJFAV8wOXuCExV8cBXQkiWEfU=n7nm-a8MR=h9k-2Z2CU9ZE-g@mail.gmail.com> (raw)
In-Reply-To: <1589615919-14888-1-git-send-email-wangyunjian@huawei.com>
On Sat, May 16, 2020 at 9:59 AM wangyunjian <wangyunjian@huawei.com> wrote:
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> The 'group_status' has never been used and can be removed.
>
> Fixes: 94c0776b1bad ("vfio: support hotplug")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> lib/librte_eal/linux/eal_vfio.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/librte_eal/linux/eal_vfio.c b/lib/librte_eal/linux/eal_vfio.c
> index d26e1649a..289f06650 100644
> --- a/lib/librte_eal/linux/eal_vfio.c
> +++ b/lib/librte_eal/linux/eal_vfio.c
> @@ -929,9 +929,6 @@ int
> rte_vfio_release_device(const char *sysfs_base, const char *dev_addr,
> int vfio_dev_fd)
> {
> - struct vfio_group_status group_status = {
> - .argsz = sizeof(group_status)
> - };
> struct vfio_config *vfio_cfg;
> int vfio_group_fd;
> int iommu_group_num;
> --
> 2.23.0
>
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2020-06-29 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 7:58 wangyunjian
2020-06-29 9:44 ` David Marchand [this message]
2020-07-07 11:50 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wOXuCExV8cBXQkiWEfU=n7nm-a8MR=h9k-2Z2CU9ZE-g@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jerry.lilijun@huawei.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).