From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37C22A00C3 for ; Wed, 30 Nov 2022 08:13:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CC2342BD9; Wed, 30 Nov 2022 08:13:47 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7B68540151 for ; Wed, 30 Nov 2022 08:13:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669792425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xf0w9SqAlnDRNO/lRBv1vE8sILCCj1xSxgFwXtLpJHE=; b=WUNc4mTNmGsBuMyWiUtRh9eRPy++lZ1/W+kdXPuzrweJid5Htgwnx1aGV2Hb4F43h4nUzq DbmDcely7TZqFScfIlIEUAmURyWhUrYS94aJqKNSubkQA2J9XxtS42x+Oq7cksu9QSogqO NwKjI83YH+rtICSN1iKwVDuhCa/2Bl4= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-372-jiZBLUFQMPqNRrK_qZmwfA-1; Wed, 30 Nov 2022 02:13:43 -0500 X-MC-Unique: jiZBLUFQMPqNRrK_qZmwfA-1 Received: by mail-pj1-f71.google.com with SMTP id f4-20020a17090a700400b0021925293dcfso1157855pjk.8 for ; Tue, 29 Nov 2022 23:13:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Xf0w9SqAlnDRNO/lRBv1vE8sILCCj1xSxgFwXtLpJHE=; b=IOi6+UjLKK98wyhB7ugVNkF+zfumh6zw8YurPC51I7g0z7PSkt0gXq4WgOEm41tPUX F7XGmIPdG1h6dhtsKggeVFjB7cp2fdcjkV2/ySE4eeI3ch5v0XTYxE/wwHjyyj2u/YoZ gNGdN/PCS32cX3CokoKimSJW0RPWUGC521CGWlOfOkg9/t9lhHpqQzgJyQoryOB4r0Xo RA+I/7HE2X2VYVoCX2aJLtF/hL/j5UA6QobMYbSQbeEhcs0kBf2JreVbi5E/ZsK8oVhm S36FKup668kj7YRAjM1+9zczO4JsbhJ8z2qg9hHct+0CzrqAiCnOfPS3rJPnsGeDCjiA T5fQ== X-Gm-Message-State: ANoB5pkIu+KD/TcVjirIEtaQxtXN0C8JPqZn3M0saAuUlFkFuc7j9nyz voTdvMMk3+PF7BEzvAmzlZWv+mc3ZNWTZle0mrIiledsR9mGWmWxabZk9TeHH6lU4sZLLPOuYS8 5bYNDBBUGfAPbS4cJBcyGDK8= X-Received: by 2002:a17:902:dac2:b0:188:f5c7:4d23 with SMTP id q2-20020a170902dac200b00188f5c74d23mr41992782plx.125.1669792422277; Tue, 29 Nov 2022 23:13:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf5hVkQ0ONaabimllqG5i4ezI+ZfXkTkCyHqHlbYITiXDFslg3Xml4n0l4xxZjrNgMtksXS0VEUz6QXLVNPQz8c= X-Received: by 2002:a17:902:dac2:b0:188:f5c7:4d23 with SMTP id q2-20020a170902dac200b00188f5c74d23mr41992766plx.125.1669792421956; Tue, 29 Nov 2022 23:13:41 -0800 (PST) MIME-Version: 1.0 References: <20221129140032.35940-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 30 Nov 2022 08:13:30 +0100 Message-ID: Subject: Re: [PATCH] drivers: fix symbol exports when map is omitted To: Ferruh Yigit , Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, Luca Boccassi , Bruce Richardson , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Nov 29, 2022 at 7:23 PM Ferruh Yigit wrote: > > On 11/29/2022 2:00 PM, David Marchand wrote: > > ld exports any global symbol by default if no version script is passed. > > As a consequence, the incriminated change let any public symbol leak > > out of the driver shared libraries. > > > > Hide again those symbols by providing a default map file which > > unexports any global symbol using a local: * catchall statement. > > > > I assume this will cause warnings for ABI check scripts, how can we > prevent the warnings? Indeed. Some options: - add exhaustive suppression rules in devtools/libabigail.abignore, - retag the v22.11 release with this fix, but we already announced it and people started downloading the tarball, - release a .1 version and compare ABI against it (either in the main repo, or in the 22.11 stable branch, through for the ABI check in GHA, it would be simpler to have the tag in the main repo..), Do you have other ideas? > > > The check on symbols is skipped for this default map file as it is > > intentionnally an empty map (see commit b67bdda86cd4 ("devtools: catch > > empty symbol maps")) and there is nothing to check in it. > > > > How it is skipped, './devtools/check-symbol-maps.sh' still complains > about 'drivers/version.map' for me. I had considered the call check-symbols.sh during build. But it is true that if you call check-symbol-maps.sh alone, we will get a warning. I will exclude it in v2. > > > While at it, move Windows specific objects where needed for better > > readability. > > > > +1 > > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded") > > Cc: stable@dpdk.org > > > > Reported-by: Luca Boccassi > > Signed-off-by: David Marchand > > > Not tested on Windows, but for Linux: > Tested-by: Ferruh Yigit UNH Windows tests look fine. -- David Marchand