From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f193.google.com (mail-vk1-f193.google.com [209.85.221.193]) by dpdk.org (Postfix) with ESMTP id 1C34C5F2D for ; Tue, 18 Dec 2018 11:29:30 +0100 (CET) Received: by mail-vk1-f193.google.com with SMTP id w72so3550768vkd.5 for ; Tue, 18 Dec 2018 02:29:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XAXEXQD/5Zs050ddooeT4CZyAfvi17sern4w5jvlh+8=; b=H1UT/Lhfo4KwCgdE7AjKXyYlqt2rsuqD6u1goZXwtH6N68X2zHzhnaZI28mCyXLX90 ZubX64EoWOq010aUWlAL3mxWB6FUILZo7bCHePQxLD+/j2q6Gw7xem1c8uPT8tF9E3c+ njtOBJtWyYV7igndlxqWT8ZH9iEDtpz5GqFF8drepXMJL0RLdVsRryXtBm2pRWqR5gAS u8/Gn3qV5ABB5T02TPrGOsaJdavEIWRhMubEpX070oTBSgjaUDPcrBzVM6fY/eyvEaft N5QYHQMUT+3aRT/kIFSahqMKzy1c3YEup/2tCdmklAH7WQVEnQ0O3e0jhNXLmeB/tbZk UMjA== X-Gm-Message-State: AA+aEWbeBLx8pJsACS5Gbb5dOuwtCjTuY+y7nQleo3l60qT6mQ0IO2vJ ZeBNk1H1gN+Od7bUC+Kpg4ZDWC2ggf3EkvjXz4lUMg== X-Google-Smtp-Source: AFSGD/WIWsMPTvvhRjrbADzFmT7eIhkA0b+xZkH04bIgHX4tmJ4IGZYsamksgBw80jNh3LyKqwkPRUB0jOdIfTHLd0E= X-Received: by 2002:a1f:ac4:: with SMTP id 187mr7276706vkk.31.1545128969525; Tue, 18 Dec 2018 02:29:29 -0800 (PST) MIME-Version: 1.0 References: <1543912111-8106-1-git-send-email-david.marchand@redhat.com> <20181204151853.GB31778@hmswarspite.think-freely.org> In-Reply-To: <20181204151853.GB31778@hmswarspite.think-freely.org> From: David Marchand Date: Tue, 18 Dec 2018 11:29:17 +0100 Message-ID: To: thomas@monjalon.net Cc: dev@dpdk.org, stable@dpdk.org, Timothy Redaelli , ferruh.yigit@intel.com, ivan.malov@oktetlabs.ru, arybchenko@solarflare.com, Neil Horman Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [PATCH] log: add missing experimental tag X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 10:29:30 -0000 Hello Thomas, On Tue, Dec 4, 2018 at 4:20 PM Neil Horman wrote: > On Tue, Dec 04, 2018 at 09:28:31AM +0100, David Marchand wrote: > > When rte_log_register_type_and_pick_level() has been introduced, it has > > been correctly added to the EXPERIMENTAL section of the eal map and the > > symbol itself has been marked at its definition. > > > > However, the declaration of this symbol in rte_log.h is missing the > > __rte_experimental tag. > > Because of this, a user can try to call this symbol without being aware > > this is an experimental api (neither compilation nor link warning). > > > > Fixes: b22e77c02620 ("eal: register log type and pick level from args") > > Signed-off-by: David Marchand > Acked-by: Neil Horman > Can you pick this fix ? Thanks. -- David Marchand