From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0057BA0093 for ; Thu, 17 Mar 2022 14:15:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AA594067B; Thu, 17 Mar 2022 14:15:32 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id CB1744067B for ; Thu, 17 Mar 2022 14:15:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647522930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QAtTmWNNcCh3/IPwHKBvJfysT4rq0pmpfIlATRRnyhw=; b=Va8vn4ChCwMoDotho6IWhw3Cdv8yLfQXZ0Ikph7N1+gt9VNm0X0/UjXg3ghqRT+W5LeeSX l8kGiS0eyAun9Ly9OWp40+5KkuEAXT+gTwWCuru5zlvCW2jdves798zYxRZnc+hFHz0gIP flQ49fTfm7xMVuTcWGaomb3uOD/ORUg= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-3N6TErC8M8KXi2TR2-8Jhg-1; Thu, 17 Mar 2022 09:15:28 -0400 X-MC-Unique: 3N6TErC8M8KXi2TR2-8Jhg-1 Received: by mail-lj1-f197.google.com with SMTP id o8-20020a2e9448000000b00246133c54deso2064813ljh.10 for ; Thu, 17 Mar 2022 06:15:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QAtTmWNNcCh3/IPwHKBvJfysT4rq0pmpfIlATRRnyhw=; b=Lzrn4d1D4cCysVwW3xMR73qN44ZR32fnOt3Se6SLJ/pQmkguA61lGfx95TpiXW4Llc YEAvj7Jq+RC3LkCdEe+Se+mVCGIkisvCy/lEd6VnK63wtauyI1PF82Afid3A1DhEnSHL s44jvpwA/1w1FE2YexBYEEPxLPCTJK3bicigTKibrl5LLA4JQjWkKydYKLBCTKZtw9h2 2Y++a5qiyroqzWc0LMin8IlQrehxLnG7JettxNPF1UjY5dC4bGsi3ybd43Koh9jRmSWP LxYIZH0vW84Nix3Ln5/6Rcd5mOZfVZWH4mknDSmz8h8ymEEAuSTv/DjaBzPpIHO0CTED 6l5A== X-Gm-Message-State: AOAM532lIRO6jI6yfyQouqzRqe12lAP/Sr6zJ8GPDw8f9J6LUFRpR/Vj nBtp2mzIP+zI4iwSo9EXGzUKhi0u73Dg1TQ+ADrwIiOwQi0iR2LweQ7h6gwWp16g2ReJcilopad P8uIk9IMlevkT3mvWpRxkFoI= X-Received: by 2002:a2e:a37a:0:b0:22d:7f2b:23c with SMTP id i26-20020a2ea37a000000b0022d7f2b023cmr2882866ljn.81.1647522927193; Thu, 17 Mar 2022 06:15:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIjme7CDHuz9+bSysm5zkx2Y8EEt8NIvfWAt4FYRHwMNiWZ+HYQbLqnrJnhMtO/R8ESe4YIYnEdPrENhk89EM= X-Received: by 2002:a2e:a37a:0:b0:22d:7f2b:23c with SMTP id i26-20020a2ea37a000000b0022d7f2b023cmr2882847ljn.81.1647522926956; Thu, 17 Mar 2022 06:15:26 -0700 (PDT) MIME-Version: 1.0 References: <20220316122318.718039-1-luca.boccassi@gmail.com> In-Reply-To: <20220316122318.718039-1-luca.boccassi@gmail.com> From: David Marchand Date: Thu, 17 Mar 2022 14:15:15 +0100 Message-ID: Subject: Re: [PATCH] cryptodev: add backward-compatible enum To: Luca Boccassi Cc: dpdk stable , Kevin Traynor , Christian Ehrhardt , Luca Boccassi Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Mar 16, 2022 at 1:23 PM wrote: > > From: Luca Boccassi > > The enum was renamed to fix a typo in main, and backported. > But in the stable release we want to keep backward compatibility > when possible, so also define the old name so that both old and > new code will work. > > Fixes: 7b5609a5a0e7 ("cryptodev: fix RSA key type name") > > Signed-off-by: Luca Boccassi > --- > Thanks David for the report. Might be interesting for other LTS branches too. > > lib/librte_cryptodev/rte_crypto_asym.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h > index 9c5bb9233a..8133a31ad4 100644 > --- a/lib/librte_cryptodev/rte_crypto_asym.h > +++ b/lib/librte_cryptodev/rte_crypto_asym.h > @@ -147,6 +147,8 @@ enum rte_crypto_rsa_priv_key_type { > RTE_RSA_KEY_TYPE_EXP, > /**< RSA private key is an exponent */ > RTE_RSA_KEY_TYPE_QT, > + /**< Backward-compatible definition of old name */ > + RTE_RSA_KET_TYPE_QT = RTE_RSA_KEY_TYPE_QT, > /**< RSA private key is in quintuple format > * See rte_crypto_rsa_priv_key_qt > */ You should move this compat item after the comment. Idem the doxygen tag should be *after* the new item. Like: diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h index 9c5bb9233a..d59e05323e 100644 --- a/lib/librte_cryptodev/rte_crypto_asym.h +++ b/lib/librte_cryptodev/rte_crypto_asym.h @@ -150,6 +150,8 @@ enum rte_crypto_rsa_priv_key_type { /**< RSA private key is in quintuple format * See rte_crypto_rsa_priv_key_qt */ + RTE_RSA_KET_TYPE_QT = RTE_RSA_KEY_TYPE_QT, + /**< Backward-compatible definition of old name */ }; /** I tried this patch (after moving the hunk after the comment) on top of current 20.11 branch. It fixes the ABI check (more a API check in this case). -- David Marchand