From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1CB94A00E6 for ; Fri, 17 May 2019 10:16:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBB8E5B16; Fri, 17 May 2019 10:16:41 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 30A2758EC for ; Fri, 17 May 2019 10:16:39 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id g187so4070614vsc.8 for ; Fri, 17 May 2019 01:16:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vvpogwqmOpEPA3adRYRktoG3dnzxgj95J/aMs/B6Tlo=; b=K3SgZ13t+Q2lTLc3XVk+sFYwj0DLJzSe2oiT4UcG+cGIoboWT/NUnRMrykwOhN4plY voOG5rCC7ylcppHz56WUnZRxgnwh+o0uE0njBhA9aU0iNHHRwPpsMA8vIHQ4KOllKC9s 5F4z9+yt5y8MicnkcOAhIxGJcrDKWCo57bsHqZbWX+ULBd+AFdudPQrWg5/NmzltXp73 QsvHy7KYXx0B41gCXVJSF3KU1GiDP8G2oxW+hGchci9o95hdDKVawQTSn8g8L9vT58yH WugXJ8d1gJ+xgf0QTSg5h82PjnSoFtrnSnv+2z2uHw8LYEbhFVN9dl7FitjhaMAvCvae KJRQ== X-Gm-Message-State: APjAAAUPXE4g3XhdKujCxh8bgEgSheKy/7q2AKC9WeGnv3LlFJkr+x6X Lb3lj3pWlLK1jyTeAo8HDq1+6UuPEG8R9aM8AZSwUQ== X-Google-Smtp-Source: APXvYqx8YPkEgEiy4MEGN87cciPB83pF/Gkblq9YaPfAi6xlQ/uzij4vZ2p0GVW8MPogWv428Pq3q076eutkP3zNHGs= X-Received: by 2002:a67:61c6:: with SMTP id v189mr10462123vsb.198.1558080998601; Fri, 17 May 2019 01:16:38 -0700 (PDT) MIME-Version: 1.0 References: <1557389028-2462-1-git-send-email-david.marchand@redhat.com> <20190509132901.nvcvz374pi53mnip@jenstp.localdomain> In-Reply-To: <20190509132901.nvcvz374pi53mnip@jenstp.localdomain> From: David Marchand Date: Fri, 17 May 2019 10:16:27 +0200 Message-ID: To: Jens Freimann Cc: dev , dpdk stable , Maxime Coquelin , Tiwei Bie , Zhihong Wang Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/virtio: remove useless check on mempool X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, May 9, 2019 at 3:29 PM Jens Freimann wrote: > On Thu, May 09, 2019 at 10:03:48AM +0200, David Marchand wrote: > >This .rx_queue_setup devop is called after ethdev already dereferenced > >the mempool pointer. > >No need to check and we can remove this rte_exit. > > > >Fixes: 48cec290a3d2 ("net/virtio: move queue configure code to proper > place") > >Cc: stable@dpdk.org > > > >Signed-off-by: David Marchand > > Agree, the pointer is accessed before in the caller. That said, afaics the > pointer is never checked in rte_eth_rx_queue_setup() before it's > dereferenced... > Yep, sent a patch. http://patchwork.dpdk.org/patch/53503/ Thanks for the review Jens. -- David Marchand