From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B04C4A0C4A for ; Wed, 16 Jun 2021 10:35:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BF62410E9; Wed, 16 Jun 2021 10:35:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 76EF1410E9 for ; Wed, 16 Jun 2021 10:35:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623832500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=03KMBQk3HqturwjEFKKYD+CWpvdZUx4S5zSeO9Jhjq8=; b=Ll/tuhy2Z4H/yi2inkfYNjazD0Cz/mVa53H3ZAUa62ojWsUUYHKGrSspHzTOAz1+fXaH4x msbbz5dMaTxNB9Y2VGXCgAPu+BCdiIZp6nvoQuLcFEQc+LEdpbRdgPxhZDML7LlRKEr/8H kTcX8jlFtDOzqPsYDBFrUqNQmGShRVw= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-K8Ih5RcKOzSEgQ9ySZIU0g-1; Wed, 16 Jun 2021 04:34:57 -0400 X-MC-Unique: K8Ih5RcKOzSEgQ9ySZIU0g-1 Received: by mail-ua1-f72.google.com with SMTP id f2-20020ab006020000b02902124881cdf4so734067uaf.7 for ; Wed, 16 Jun 2021 01:34:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=03KMBQk3HqturwjEFKKYD+CWpvdZUx4S5zSeO9Jhjq8=; b=bnjvvQDci7Ks3qQqCqX5Pkp+1eqGv0PiWiMxO3ahUrsRCAw9aq5GQimjLTukk17Vg/ BQs893pmcWyHgr9SZpSuRDWgjcY6N8XQZXBPH+1NwAM6UHsEknwZ8L1GKzdy927yP7WH wUWKbA0DQanxzkV7e/3W9PbqjA3vX2u6MDzWnqa76DDNAooMUU1LVXZGB8bj7fTKRK0F bIvaBOe71Nltdz/I3epw9bvf/8RisRMO8t78iU4EUaMaRsPq+R8IsF5Wp7NOgAenYRWt go5yYdlaKBSXcqOCasDNdVAcbyp2zpm9zAvKOG1QIqAVw6a7QC3+Vclvd67hq0ajJOo5 qaXg== X-Gm-Message-State: AOAM531z/WIgzwZB22Px5L7t2spuzgv5AaMxtPsEFCVLawfqXgQGPjAX n9Y2Q8sC38g9OkqdIqBseauOFy4EzeWbv3ONkWE1jekJVXU4XG5B43AtzDlPQjYoVmGOIrGlqNG rnPFwRMo3cYfZc4KT+5kFnHo= X-Received: by 2002:a05:6102:243c:: with SMTP id l28mr9534269vsi.27.1623832496769; Wed, 16 Jun 2021 01:34:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgTw+N6nTq5jnSJwoaNzww8yMRHmjEoqiIEX/NJSPsIiWRqPskgngrA1t0yKjERKxb6K9ALDQ34xZdeyUrQYM= X-Received: by 2002:a05:6102:243c:: with SMTP id l28mr9534251vsi.27.1623832496591; Wed, 16 Jun 2021 01:34:56 -0700 (PDT) MIME-Version: 1.0 References: <20210614091213.3953-1-david.marchand@redhat.com> In-Reply-To: <20210614091213.3953-1-david.marchand@redhat.com> From: David Marchand Date: Wed, 16 Jun 2021 10:34:45 +0200 Message-ID: To: dev , Anatoly Burakov Cc: Owen Hilyard , dpdk stable , Qi Zhang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] ipc: stop mp control thread on cleanup X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Mon, Jun 14, 2021 at 11:13 AM David Marchand wrote: > > When calling rte_eal_cleanup, the mp channel cleanup routine only sets > mp_fd to -1 leaving the rte_mp_handle control thread running. > This control thread can spew warnings on reading on an invalid fd. > > To handle this situation, sets mp_fd to -1 to signal the control thread > it should exit, but since this thread might be sleeping on the socket, > cancel the thread too. > > Fixes: 85d6815fa6d0 ("eal: close multi-process socket during cleanup") > Cc: stable@dpdk.org > Reported-by: Owen Hilyard > Signed-off-by: David Marchand Anatoly, review please. -- David Marchand