From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECF6BA0583 for ; Thu, 19 Mar 2020 16:40:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B36FF1C02E; Thu, 19 Mar 2020 16:40:54 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by dpdk.org (Postfix) with ESMTP id 2C5501C025 for ; Thu, 19 Mar 2020 16:40:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584632452; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2JUvVWl/au4eOMTX7KNOxKnGngSpPvIJHCQhkmXqShM=; b=OWWhtSirtfuMx2Cz1M5DsL6z++RELdQryHczlWmsvbNU+6ZkhyA/5KdhuQqBk8Wvb002On Y4lJMUUf9RWWUEajxs8xThJUNlB6hBbogoYIT8jjZxyRx5RFttmiZFrDAx7ZWdlLGum92c 0UH9C4Gn50BswdH+c5tRhSYGNSCnDG4= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-301-l9S6F-zZMEO71kGif0y_fQ-1; Thu, 19 Mar 2020 11:40:35 -0400 X-MC-Unique: l9S6F-zZMEO71kGif0y_fQ-1 Received: by mail-vk1-f198.google.com with SMTP id f17so953000vka.11 for ; Thu, 19 Mar 2020 08:40:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FTKRQ6kzMO53XizWpATHZ+0Vmk8Banj4xDHCO9XTjVg=; b=QLUhgwHf0i40xnlXCw5s7PUQV6GEgl4MLwED0DTtAVQVXrdzZIghYUrmjN9CMb9WQi FSFrugb0a78spWPHvYsHZxYF0ktCQ/s2eh6kJBmm/nWndwXLebUGw5VVlmX32QM0pa5B 00twVPd/kYQdDXD4YPSNW9M5n7bMrPxBieAuRgThZGsh2jASXKSC368XKps/08A69tkX /IrnUTDG8hzZtMeU6D5XoVWIu6Goar25UU3ix4buGc40ebfomv+zfo37aMrGICmaZksM fSCmN5lhRErnysFGfKePWXoFuEY6cIUV2aKn2JaFCuVvpEBkQW/v1QHuo1tljkeurcU5 eKCw== X-Gm-Message-State: ANhLgQ34a7Sy83SP74q4gT3K4r3R9pGU6gAPXo3mg7P9Wrr1j5ezlLcy PoTtkoh/2ib2LQzCVrjdMBmy/Q9Rv5G9JxWXr3SBVisDhpKsBb9R73dPxbi384CYRiwIfC67NXn AvLFafoxkMOYeAbrGsNRdJxQ= X-Received: by 2002:ab0:77c8:: with SMTP id y8mr2161392uar.126.1584632434758; Thu, 19 Mar 2020 08:40:34 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsFwrUthElqyl5oGXhztiFD/ItbEYfyheTidKALM/KqkcWYK2yonh0jzpH8o6kKmCtxWCGcWEctoNj25QeQ8iQ= X-Received: by 2002:ab0:77c8:: with SMTP id y8mr2161371uar.126.1584632434332; Thu, 19 Mar 2020 08:40:34 -0700 (PDT) MIME-Version: 1.0 References: <20200319082859.7162-1-david.marchand@redhat.com> <60947579.3F2A3RajZp@xps> In-Reply-To: <60947579.3F2A3RajZp@xps> From: David Marchand Date: Thu, 19 Mar 2020 16:40:22 +0100 Message-ID: To: Thomas Monjalon Cc: dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH] doc: prefer https when pointing to dpdk.org X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, Mar 19, 2020 at 10:01 AM Thomas Monjalon wrot= e: > > 19/03/2020 09:28, David Marchand: > > for file in $(git grep -l http://.*dpdk.org doc/); do > > sed -i -e 's#http://\(.*dpdk.org\)#https://\1#g' $file; > > done > > > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > --- > > + # links must prefer https over http > > + awk -v FOLDERS=3D'doc' \ > > + -v EXPRESSIONS=3D'http://.*dpdk.org' \ > > + -v RET_ON_FAIL=3D1 \ > > + -v MESSAGE=3D'Using non https link to dpdk.org' \ > > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.aw= k \ > > + "$1" || res=3D1 > > Interesting policy. > When no authentication is required, I was trying to use simple http, > in the hope of making access faster. > What is the benefit of https for documentation? Avoid man-in-the-middle? People probably don't notice the little extra time required to load a page via https. Trying to go to dpdk.org with simple http: gets you redirected to https:. Then you browse down to the documentation with https, and finally you find some links in https. This is odd, but not a problem, I agree. All in all, I prefer a simple policy that works in most cases rather than this rule that we must be aware of when reviewing doc patches. --=20 David Marchand