From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9866CA0032 for ; Wed, 16 Mar 2022 09:06:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 683C740395; Wed, 16 Mar 2022 09:06:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 63CD340395 for ; Wed, 16 Mar 2022 09:06:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647418008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YROR+/dBKPvBXkUwCqAC27IRR7ZWEb0wWWFCphxmcfU=; b=U9RknJjlbi9qqQX3MzJ3iT/bGEWt/6jk3cziKhwZ9ah/cfQ9l1vFP2JLJjXbUEEc7sZ/js DiB4Qld4SxxXGoljTjmPFoLK6dR+rz1g+4C8MWbd9P3NjDThGaV5nEOBeDWQORLt2faU+Y MzLWmhUevEIak3BOpNzxkKPe5g5GGOU= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-557-fTB4ZQ3hMkGmMCqReVbONQ-1; Wed, 16 Mar 2022 04:06:45 -0400 X-MC-Unique: fTB4ZQ3hMkGmMCqReVbONQ-1 Received: by mail-lf1-f69.google.com with SMTP id w25-20020a05651234d900b0044023ac3f64so507484lfr.0 for ; Wed, 16 Mar 2022 01:06:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YROR+/dBKPvBXkUwCqAC27IRR7ZWEb0wWWFCphxmcfU=; b=lpJgrO8EU/nIL40Ihk5BNgcnDEfn0Xrm8Hb3XBPLGZYvWlk3okuduUG7mxGCG6F3Ct L2pwrs0RtDo/He2LXQ5mLEVEzFWNUMzfKBS4WHFCwkNyoq8OkCRAeMjaTVOvv8WbHATO PLCgffYv1ojH0gQ8m1ACGdfJn1Mz7K4Ao7sQQBgNtC2EHEClXM8I/ln6Fxdv8dXcBfFQ AFILkIaWcuVPPqz1ZWqeyLIyWfT7luu2/99cPAaoAjKx8jvnoI604fA+JPVQ3KsJOkP0 ROGhiqAU+olZLpjRyoLRNMYqrQSGBhzExBiqjpovVvcBgMR68quh7I4l4ZsxZXXEXPyT Dtsw== X-Gm-Message-State: AOAM533rpb4Um6lA9IktrL16nswvTZI2oHs6mOKHEUGHr+lQsRAfTVHi hF0tNBsYcHO9d1Bna8lFvdgV+iaNft7MHXV+fs2Ne9qKKis1DhAe7FtNeEQOPILMqRePeK3n0JY uI2IhaHnriy4ZEkFgMkjKEfo= X-Received: by 2002:a05:6512:398d:b0:448:5f9e:d992 with SMTP id j13-20020a056512398d00b004485f9ed992mr17491238lfu.553.1647418004168; Wed, 16 Mar 2022 01:06:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzm48/aCX4TC0+II/aH6WNTBr+Le0IKoNovgGyx9bWOXaCt6S+hJaU4c1nOPrDOzuAiIl1aanSZTbyUEsdkkoU= X-Received: by 2002:a05:6512:398d:b0:448:5f9e:d992 with SMTP id j13-20020a056512398d00b004485f9ed992mr17491220lfu.553.1647418003928; Wed, 16 Mar 2022 01:06:43 -0700 (PDT) MIME-Version: 1.0 References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> <20220228212047.3341966-14-luca.boccassi@gmail.com> In-Reply-To: <20220228212047.3341966-14-luca.boccassi@gmail.com> From: David Marchand Date: Wed, 16 Mar 2022 09:06:32 +0100 Message-ID: Subject: Re: patch 'cryptodev: fix RSA key type name' has been queued to stable release 20.11.5 To: Luca Boccassi , Kevin Traynor , Christian Ehrhardt Cc: Arek Kusztal , Akhil Goyal , dpdk stable , Thomas Monjalon , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello Luca, Kevin, Christian, On Mon, Feb 28, 2022 at 10:21 PM wrote: > Subject: [PATCH] cryptodev: fix RSA key type name > > [ upstream commit 3387912f5cacd934594f2c7a0c34eda7279419a8 ] > > This patch fixes misspelled RTE_RSA_KEY_TYPE_QT, > this will prevent checkpach from complaining wherever > change to RSA is being made. > > Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions") > > Signed-off-by: Arek Kusztal > Acked-by: Akhil Goyal This patch triggers a warning from libabigail in UNH tests for 20.11 and 21.11: type of 'anonymous data member union {rte_crypto_rsa_xform rsa; rte_crypto_modex_xform modex; rte_crypto_modinv_xform modinv; rte_crypto_dh_xform dh; rte_crypto_dsa_xform dsa; rte_crypto_ec_xform ec;}' changed: type size hasn't changed 1 data member change: type of 'rte_crypto_rsa_xform rsa' changed: type size hasn't changed 1 data member change: type of 'rte_crypto_rsa_priv_key_type key_type' changed: type size hasn't changed 1 enumerator deletion: 'rte_crypto_rsa_priv_key_type::RTE_RSA_KET_TYPE_QT' value '1' 1 enumerator insertion: 'rte_crypto_rsa_priv_key_type::RTE_RSA_KEY_TYPE_QT' value '1' type size hasn't changed Error: ABI issue reported for 'abidiff --suppr dpdk/devtools/libabigail.abignore --no-added-syms --headers-dir1 reference/include --headers-dir2 build_install/include reference/dump/librte_ipsec.dump build_install/dump/librte_ipsec.dump' ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue). This API is experimental, so changes are acceptable, but we are missing a suppression rule similar to what is in the main repo: ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental [suppress_type] name = rte_crypto_asym_op Note to Thomas and myself: the next time we clean those rules, the suppression rule on asymmetric crypto should be kept if still experimental. -- David Marchand