From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C451943D05 for ; Wed, 20 Mar 2024 17:30:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBFBE42D27; Wed, 20 Mar 2024 17:30:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6537D40ED3 for ; Wed, 20 Mar 2024 17:30:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710952234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZzCq1IM4neuehISaslCBvEoT+bJQ7mtyA/ErkSiAmjc=; b=VBA6ugUACx5c0/5gSF0k+DcGLH7xneLzfBRNK+FckRMkNTQc6gfhNKje75WCfNjdlx0cEx oBrNGIHtgZ+0kbJiK3hsSO7bk6lU1T+tyS/8l1Pkuv179vF6BqVUlZvpxs+kunN2B7mYQs 0E3a0PaX5pgnpIkoqHbyN9uyq+1cov0= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-2tE1CYw9Pi2hBIu-NZOYqA-1; Wed, 20 Mar 2024 12:30:30 -0400 X-MC-Unique: 2tE1CYw9Pi2hBIu-NZOYqA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-513e214be2aso69865e87.0 for ; Wed, 20 Mar 2024 09:30:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710952229; x=1711557029; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZzCq1IM4neuehISaslCBvEoT+bJQ7mtyA/ErkSiAmjc=; b=bd5xxyyDY3rqAowPJnI89SUeC00osojheVpqrVA5lvi2sXE3x/DlMdgvjrKjnaK3FH uqwAPQrqcnuourkxuhhc2SqP6B+piuevwWDhQZDp4gHR6G6QIgsvWIC+k6FcztYAOu/P 6ZFj3+LoPreubupwotBZM5mEewIpJ7xsOf7aSo8VMtCkFNpnJZgnTCWNbzMT8BXCXRQV JchDSi8djxs3C6cCzecYo+Vi+VZwLjMmuTjTB+M89HaQbIy3GE43cvKQnKCaGLnYyUPM TaeSTtHznGRbEe631VjbYvWjYnABvCMHcPn4brZKXYP8gzW0PH2whoQ/uGYTl5CXGet+ Fugg== X-Forwarded-Encrypted: i=1; AJvYcCXzIU2eqdoduolZ71ndZdVO1dnbMXk7+ejLlXY3AMW9NAxEEpbmhfRebNwfqjtNHU8EZcVKJpOZoGrCI8JxCi8= X-Gm-Message-State: AOJu0YwY7tN2uLO8/d2B4Q04hNvwZm8599VNnSvggxYHPacAr1SppRO1 NWYa3NABjUOoPzZU7rBtQw4tHz5kdjCKuOpDqjMPrsiv0F6SioUv2yFs3vrs46HQEcSnF7JAqDi s1klqMwv2k2ukkghQtcQRzW/UoZYf8c1lQUuG1HkPErjgmvLgWNEzZ7sesNpTsCOrKvBPjNnJWe vQ1X896HiqHF/H/29frOk= X-Received: by 2002:a19:4318:0:b0:513:c408:b2af with SMTP id q24-20020a194318000000b00513c408b2afmr11529617lfa.46.1710952229273; Wed, 20 Mar 2024 09:30:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGjX+loBT3cipDvnXLhRrKJudxamRld5sSmJ6sc8xUq9wIV0V6OwEJbgFIc3GB38Zi7DNCmFPXIIEjJHHUYeyg= X-Received: by 2002:a19:4318:0:b0:513:c408:b2af with SMTP id q24-20020a194318000000b00513c408b2afmr11529599lfa.46.1710952228851; Wed, 20 Mar 2024 09:30:28 -0700 (PDT) MIME-Version: 1.0 References: <20240320155814.617220-1-alialnu@nvidia.com> In-Reply-To: <20240320155814.617220-1-alialnu@nvidia.com> From: David Marchand Date: Wed, 20 Mar 2024 17:30:17 +0100 Message-ID: Subject: Re: [PATCH] buildtools: fix build with clang 17 To: Ali Alnubani Cc: dev@dpdk.org, thomas@monjalon.net, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello Ali, Thomas, On Wed, Mar 20, 2024 at 5:01=E2=80=AFPM Ali Alnubani w= rote: > > On Fedora 39 with Clang 17.0.3 and ASan enabled, > RTE_PMD_EXPORT_NAME seems to be done twice for a single > lib, which results in load_drivers() returning a list > consisting of 2 drivers (e.g., ['mlx5_common_pci', '']). > image.find_by_prefix("this_pmd_name") returns 2 symbols in this case, > "mlx5_common_pci" and an empty string ''. This didn't reproduce > with clang version 16.0.6. > > This patch ensures that a symbol with an empty string_value doesn't > cause an addition to the list of drivers. I suppose this comes from ASan instrumenting the code: # nm /root/dpdk/build-clang/drivers/libtmp_rte_common_mlx5.a | grep this_pm= d 0000000000000000 r this_pmd_name3 0000000000000000 n this_pmd_name3.e5676185d74e2e1a9de646deebca963f 0000000000000000 r this_pmd_name3 0000000000000000 n this_pmd_name3.a2533baf7a46959f41383725087d4086 The name of the symbols this script should look for has a clear format, which is this_pmd_name[0-9]+. Filtering with this pattern, there would be no need to go and interpret a symbol content. --=20 David Marchand