From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB4B6A056D for ; Fri, 13 Mar 2020 10:33:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9EA0B1C02C; Fri, 13 Mar 2020 10:33:40 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 4CCF81BFFE for ; Fri, 13 Mar 2020 10:33:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584092016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dQTyqWL4Zt66lcqgB8WkcQhJIkpB35vjHuy3a3axfpY=; b=OQ7niMrKk2bEhiVxNiagedvQxXT4kRIIHb+bQ9j9kV+qgfkiOEKfW/8vdDUR1RWPycIq8q NseSypWgQZ//Jhpz3M1EM5O0q01Q+A9JIa/vU2s7J87UhL8FPCAKb9o1zPRg+YwLDh+zy5 7iVdpFA1WcbrfN+M1n5oYaLnXIA+HhU= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-0UZmwYrUO22H2SOJrK4oGA-1; Fri, 13 Mar 2020 05:33:34 -0400 X-MC-Unique: 0UZmwYrUO22H2SOJrK4oGA-1 Received: by mail-vs1-f70.google.com with SMTP id 123so896218vsg.2 for ; Fri, 13 Mar 2020 02:33:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n46A27bELEBDjEt263gpMidUFf8K4at8r81HFy2Cx08=; b=FaTFqnAqNE2NEsxu18PIP3OYYcipp0fMuKzAzRC+6QeXyZ+hpfEPDiAfHkFR4Xr4z5 LY9f+GcCvSLU21Am/60rXxlMEFtTZ/jt4RCsbSa8N5/nuYMUYNZnPpDmFGv4pCigR68G irLVTJTg3yYoZX40jn1ZxOMsIo9dTvmotFAJufOk1b87e5uOaVi+6SFWTbeDDQuyRJil aRgUe2pOU5NzmlkcEAIcwajVS1r6QidLAF3XeaBqw+zQMYEm2x1i762Ky0wAiAC046it 4wjhNrG6Bg5m+uykuxzCU7GPk4VXTpUFJXgdZqOC0KSyeTjQ//zxzg34lO+R8etw3HkQ 6Blg== X-Gm-Message-State: ANhLgQ2c4RVYokafYqyHqJ37ZnZ5N2f9jazzAXHzzbkRCPVFkVhY3+6T LmL3QAMLGYYqQZyD4EyhIqersZj5Gfa7UOfPud32Mi7HCSE5zBom3rD0UY9Pxbp5y7/L2kIwNyS tAjMlio0ZJNKWzr2mcuEa4MM= X-Received: by 2002:a67:69d8:: with SMTP id e207mr8833613vsc.141.1584092014379; Fri, 13 Mar 2020 02:33:34 -0700 (PDT) X-Google-Smtp-Source: ADFU+vu2wD/AhBOqnCf76cOS6hF31/CPRTwdGvOu8/XLMMwrM/yAhXd2rdzC7gJ+GfjS7Xohxu1ZXmT+CfJ0iyHk2AQ= X-Received: by 2002:a67:69d8:: with SMTP id e207mr8833594vsc.141.1584092014154; Fri, 13 Mar 2020 02:33:34 -0700 (PDT) MIME-Version: 1.0 References: <20200227170456.29164-1-ciara.power@intel.com> <78ab395921c74c3293ce6f0c77419d32@intel.com> In-Reply-To: <78ab395921c74c3293ce6f0c77419d32@intel.com> From: David Marchand Date: Fri, 13 Mar 2020 10:33:23 +0100 Message-ID: To: "Power, Ciara" Cc: "dev@dpdk.org" , "Pattan, Reshma" , "stable@dpdk.org" , "Laatz, Kevin" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] telemetry: fix struct reset after value assignment X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hello, On Thu, Feb 27, 2020 at 6:34 PM Laatz, Kevin wrote: > > > The ep struct is used to track what type of stats are required by the c= lient. > > For PORT_STATS type, it contains the lists of port and metric ids to qu= ery, and > > the number of ids in each list. > > > > The ep struct has values set (num of port and metric ids) when a reques= t for > > port stats values by name is received. However, after this value assign= ment, > > the struct is reset to all 0 values, meaning the number of port and met= ric ids > > required now both show as 0, and the client will not receive the reques= ted > > data in response. To fix this issue, the memset call is now moved above= the > > ep struct value assignment. > > > > Fixes: 4080e46c8078 ("telemetry: support global metrics") > > Cc: reshma.pattan@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ciara Power > > Reviewed-by: Kevin Laatz > For the title, how about: telemetry: fix port stats retrieval I can fix while applying. --=20 David Marchand