From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 497F4433B5 for ; Fri, 24 Nov 2023 09:02:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F82C43252; Fri, 24 Nov 2023 09:02:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 791C2402B3 for ; Fri, 24 Nov 2023 09:02:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700812945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AUPJYtMKohFwekvPrtmO+faTvZfSgWSXNvnms9b+0Nk=; b=Vjn6WTqV3RQL0gKY+DAZ9z4TNZRL9CtMM1tdNjYsEMgvOW1+CPjw5PdpP2MtRbOzGvZlY3 5l3+48FNzceFxYshLtBcb48k/OrRvrQdK38Z4Xtfab0g3sazyoUVjuBLxPvj/Xnt3lQtld EweNvoeCqlY3U52i0+wy1tkiIwCfEek= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562--S6IDwTPMrmnepqbpkOfsA-1; Fri, 24 Nov 2023 03:02:21 -0500 X-MC-Unique: -S6IDwTPMrmnepqbpkOfsA-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2c876d239e6so13128411fa.1 for ; Fri, 24 Nov 2023 00:02:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700812940; x=1701417740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AUPJYtMKohFwekvPrtmO+faTvZfSgWSXNvnms9b+0Nk=; b=bcy3ppDd2U3GM9E53gX7/mCT/QkjVKD2LeZbBr0yO+UWG7zI2aw8LOVHpkBU0cH6Ty PxAWQBOLLld3I9kpBq1748EHdSVbcx/xp4ILHdWFr1dZ4eIcL+KCSk7/yR0u2XlJvqoe pUaJoC6U636Bi7QGUDrx/UH5sKi1Db0V2S9YopAQbvtF88yPBb2K8m22xmzBXOXte0ZE N2EjFkOSaPgzqrRvTPLA3majrUiIhuzD6NzQiibvrVADJDn7DBv1ocvZ2pPLueEzkDGJ tZRpj84o4RQ9JSw4f7/extgLsPnNC/R0E/b2/BXvXDQQ2CUk3656Ow1oH605Tnydh1p4 q04g== X-Gm-Message-State: AOJu0YwoU16YOtlFDd8RLVkM5VWhev9u0XXLFmWCx2sU3YpYusyUeSyB xmQ6SKhB4lMZ7su7X5zeaACodYgjh6CRf9Em3EKbSGCH+Kpf7OsKfc7nbVVuU780tWrysY60EfO Iz9r1DM9tOnzY/9M7sWFkpFU= X-Received: by 2002:a2e:8387:0:b0:2c8:8745:8f0b with SMTP id x7-20020a2e8387000000b002c887458f0bmr1147446ljg.47.1700812940233; Fri, 24 Nov 2023 00:02:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IGF/dI41zrO/eF03BaeYAiAo0sM+cT5tIYLu/TPj7uxvbGam456Y0IAbQgXwkJP6R9Dk5kTcuVcAonEuTjw1L8= X-Received: by 2002:a2e:8387:0:b0:2c8:8745:8f0b with SMTP id x7-20020a2e8387000000b002c887458f0bmr1147431ljg.47.1700812939785; Fri, 24 Nov 2023 00:02:19 -0800 (PST) MIME-Version: 1.0 References: <20231124064441.1774807-1-kaiwenx.deng@intel.com> In-Reply-To: <20231124064441.1774807-1-kaiwenx.deng@intel.com> From: David Marchand Date: Fri, 24 Nov 2023 09:02:08 +0100 Message-ID: Subject: Re: [PATCH] net/ice: fix tso tunnel setting to not take effect To: Kaiwen Deng Cc: dev@dpdk.org, stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com, Qi Zhang , Jerin Jacob , Tyler Retzlaff , Somnath Kotur , Ajit Khaparde , Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, Nov 24, 2023 at 8:27=E2=80=AFAM Kaiwen Deng wrote: > > The Tx offload capabilities of ICE ethdev doesn't include > tso tunnel, which will result in tso tunnel setting to > not take effect. > > This commit will add tso tunnel capabilities in ice_dev_info_get(). > > Fixes: 295968d17407 ("ethdev: add namespace") This Fixes: tag is wrong. > Cc: stable@dpdk.org > > Signed-off-by: Kaiwen Deng > --- > drivers/net/ice/ice_ethdev.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index 3ccba4db80..fbc957fcd8 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct r= te_eth_dev_info *dev_info) > RTE_ETH_TX_OFFLOAD_TCP_CKSUM | > RTE_ETH_TX_OFFLOAD_SCTP_CKSUM | > RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | > - RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM; > + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | > + RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | > + RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | > + RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | > + RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; > dev_info->flow_type_rss_offloads |=3D ICE_RSS_OFFLOAD_ALL= ; > } Is this tunnel + tso feature supported with vector drivers? Is there some documentation to update to reflect this addition? --=20 David Marchand