From: David Marchand <david.marchand@redhat.com>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
dev <dev@dpdk.org>, "dpdk stable" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3] eal: fix crash when the random init
Date: Tue, 21 Apr 2020 18:17:48 +0200 [thread overview]
Message-ID: <CAJFAV8wqd5Ji_unHoFtBLzkPjR-hfeSwo309mch4WHKvTQddgA@mail.gmail.com> (raw)
In-Reply-To: <1586972466-40703-1-git-send-email-xiangxia.m.yue@gmail.com>
On Fri, Apr 17, 2020 at 1:37 PM <xiangxia.m.yue@gmail.com> wrote:
>
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> When rte_rand_init is invoked, and the kernel running dpdk does't
> support *getentropy, at the same time, the cpu does't support rdseed,
> then rte_rand_init invoked rte_get_timer_cycles.
>
> If HPET was enabled in the DPDK build (CONFIG_RTE_LIBEAL_USE_HPET=y).
> rte_get_timer_cycles will invoke rte_get_hpet_cycles while *eal_hpet
> is not available.
>
> To fix that, use rte_get_tsc_cycles instead of rte_get_timer_cycles.
>
> Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-04-21 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <586680073-11075-1-git-send-email-xiangxia.m.yue@gmail.com>
2020-04-15 7:43 ` [dpdk-stable] [PATCH v2] " xiangxia.m.yue
2020-04-16 16:12 ` Mattias Rönnblom
2020-04-15 17:41 ` [dpdk-stable] [PATCH v3] " xiangxia.m.yue
2020-04-21 16:17 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wqd5Ji_unHoFtBLzkPjR-hfeSwo309mch4WHKvTQddgA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).