From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7DCFA0598 for ; Tue, 21 Apr 2020 18:18:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B60F31D518; Tue, 21 Apr 2020 18:18:05 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 8488B1C1F7 for ; Tue, 21 Apr 2020 18:18:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587485883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NWq+o80IJcK3MRH6LpOWKx+IlayHhgK0lDWON1u4fK4=; b=H7Krlz2As+Qc86Xg84Zyz5Atsawp6WsVKb+ORZM5SBZLP4VWI3JMh1mF91k5ELrtFJ4Ki4 NC+vZQXHvt2DJHve+z9OfcQDbkY8hEh/nuvU4m75Vg2SsmNuyGKeWRD384rFL+i6fvMKs5 ymZVKEn8TeB3/MIDbTzNKCuBGIoDg3s= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-57HDB2dGNzOFi7QhQ8pJdQ-1; Tue, 21 Apr 2020 12:18:00 -0400 X-MC-Unique: 57HDB2dGNzOFi7QhQ8pJdQ-1 Received: by mail-vk1-f199.google.com with SMTP id h63so5529921vkh.10 for ; Tue, 21 Apr 2020 09:18:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NWq+o80IJcK3MRH6LpOWKx+IlayHhgK0lDWON1u4fK4=; b=NNgLyAPMmb8qdl7JYD6JkKG+slVAMWMF52jZUGgYF7EG2FgCKZ7A0+UwtwgjcoMx19 Lq/rDFEXRe6KMNP1Enkj2GEuRLE/aiWXJzH2VcYts2zj8dx3WPBsJmc5cXk7OWH6gc5E ppXO8nyUU+Tw1b0g4EULoxRLuOSAO+lzd9woZAacAVZ96sZZq/FbcQfnxy4hqAjToW9u r/5fiyOdUBfMhpU8W8x6hqFAcuHMNHI7rDLT/xu9qHoABm8rpDpUjbo3RyB7fL5I7z5j nWtFBvZLFwGh4rhF4kr3UJRtYLk7gFaL2YyrcbLx9ju2u87otGL1ln0GrJcFC+wv7cqu lsWg== X-Gm-Message-State: AGi0PuYuP87xa3VJUrS9IPGQ7ypuDZlvksdurZ1yPdMLivejfOn3EED2 Xk80NZ0DiZR6uNWslIHA/MR89O769j8MwQdhSuym3uch2kaAJsqDykHWt2+DMHpvzYVy3fuvx3k v4yMxXzu6nIbU3o2kOVP6/R8= X-Received: by 2002:a9f:2204:: with SMTP id 4mr12164660uad.87.1587485880335; Tue, 21 Apr 2020 09:18:00 -0700 (PDT) X-Google-Smtp-Source: APiQypJGJvNw/iJ7wrE+eDl7rLM64TvVfJJW6Z0djIFMuco7GcM8paBi3I4muK2tjSExnMlV5rAgK8ZzxsJQy1nmZ1U= X-Received: by 2002:a9f:2204:: with SMTP id 4mr12164636uad.87.1587485880068; Tue, 21 Apr 2020 09:18:00 -0700 (PDT) MIME-Version: 1.0 References: <586680073-11075-1-git-send-email-xiangxia.m.yue@gmail.com> <1586972466-40703-1-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1586972466-40703-1-git-send-email-xiangxia.m.yue@gmail.com> From: David Marchand Date: Tue, 21 Apr 2020 18:17:48 +0200 Message-ID: To: Tonghao Zhang Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH v3] eal: fix crash when the random init X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Apr 17, 2020 at 1:37 PM wrote: > > From: Tonghao Zhang > > When rte_rand_init is invoked, and the kernel running dpdk does't > support *getentropy, at the same time, the cpu does't support rdseed, > then rte_rand_init invoked rte_get_timer_cycles. > > If HPET was enabled in the DPDK build (CONFIG_RTE_LIBEAL_USE_HPET=3Dy). > rte_get_timer_cycles will invoke rte_get_hpet_cycles while *eal_hpet > is not available. > > To fix that, use rte_get_tsc_cycles instead of rte_get_timer_cycles. > > Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR= ") > Cc: stable@dpdk.org > > Signed-off-by: Tonghao Zhang > Acked-by: Mattias R=C3=B6nnblom Applied, thanks. --=20 David Marchand