From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 257F2A034F for ; Tue, 1 Mar 2022 09:44:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18D9A407FF; Tue, 1 Mar 2022 09:44:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 031C2407FF for ; Tue, 1 Mar 2022 09:44:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646124248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fe48klb2Ub5uHatuTpo7f/khRMPKQBEUp0FDjEmSy8o=; b=U+pLpObbfTZvNVhc71/Nz7jDlggFEaAU7+atYlT667KI5EROdJOZ5UU/fATilHt0lwk9jX gPHoLY8YfQN4kxkUPWHc6EEjR9eaGl1nB4veroseSR92UGdufnkm9EtLvSGiK0YdQ+7ZK9 lw5xFa61r8pixDdt7ENuanPfZxHpwmI= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-310-ut9_hx65MrCUR_A4xZSYBg-1; Tue, 01 Mar 2022 03:44:07 -0500 X-MC-Unique: ut9_hx65MrCUR_A4xZSYBg-1 Received: by mail-lf1-f71.google.com with SMTP id i24-20020a0565123e1800b0044567f5a29bso2234210lfv.5 for ; Tue, 01 Mar 2022 00:44:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fe48klb2Ub5uHatuTpo7f/khRMPKQBEUp0FDjEmSy8o=; b=VwsJqZtmhDIHyzH0PKzkq8ZUbgP4/zLM9bc2qQK6ai3qPgRIcM5BVTs95MWE2tBwd0 i/B/hLx2CCIjRUYunXLHl+BePTP/GS5HhGVBIyXu9mMXXR2a4EVzqmKRmqVzQoh7c7ig B7Rax6KjPnPl9chcYbu4H4yPfmAdS7FeA0x8djIGfGwIjgLLqrBpv28gjqwt1c2BAkyZ lKHSCHBWCsftCsiZ+sgCFi32IyAo5f903RlavgmJ8+ub7gD2BYVBSLivbvXiyEvjZI9Y s/C0wr/eitqEMBnPqwwky7x8zDhRa/A4dc5rhXz3a2DdJ0Vr7BHoufpy3IYMLRg6CSfV e15g== X-Gm-Message-State: AOAM532gfiHMxJPw1ynGAU1owrUC1RORj3Or/nyjo/PFwIBpgljgBIF9 eZh02K6iO4joDPGhfY8994djDkNmaqnSPjSbrvA+m6Ml9l8YXrnVxrpUjaN8ke6Cn3slLDTJDRv JyFAFXPEAWgidASfHoijzo7A= X-Received: by 2002:a2e:8603:0:b0:23a:6193:e2e2 with SMTP id a3-20020a2e8603000000b0023a6193e2e2mr16694493lji.333.1646124246104; Tue, 01 Mar 2022 00:44:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyCjmEpyeIHooQnKTWYRCEG27i7pe+tT6BojlS84qAN3gGqYw2kurtVmH1L2j53oyPkm2NQdoCwaNzveSttxUY= X-Received: by 2002:a2e:8603:0:b0:23a:6193:e2e2 with SMTP id a3-20020a2e8603000000b0023a6193e2e2mr16694482lji.333.1646124245914; Tue, 01 Mar 2022 00:44:05 -0800 (PST) MIME-Version: 1.0 References: <20220301072802.1349736-1-yuying.zhang@intel.com> In-Reply-To: <20220301072802.1349736-1-yuying.zhang@intel.com> From: David Marchand Date: Tue, 1 Mar 2022 09:43:54 +0100 Message-ID: Subject: Re: [PATCH v1] net/vhost: clear data of packet mbuf after sending pkts To: Yuying Zhang Cc: dev , Maxime Coquelin , "Xia, Chenbo" , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Mar 1, 2022 at 8:29 AM Yuying Zhang wrote: > > The PMD frees a packet mbuf back into its original mempool > after sending a packet. However, old data is not cleaned up > which causes error in payload of new packets. This patch clear > data of packet mbuf before freeing mbuf. This patch looks wrong to me. What is the actual issue you want to fix? -- David Marchand