From: David Marchand <david.marchand@redhat.com>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
"Mcnamara, John" <john.mcnamara@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] fib6: add runtime checks for vector lookup
Date: Fri, 11 Oct 2024 11:29:46 +0200 [thread overview]
Message-ID: <CAJFAV8wxvvam2QyTWLfcZo-SfVGjQ_r0oqdzaOCsYHyMvO5w8Q@mail.gmail.com> (raw)
In-Reply-To: <20241008173136.441340-1-vladimir.medvedkin@intel.com>
On Tue, Oct 8, 2024 at 7:31 PM Vladimir Medvedkin
<vladimir.medvedkin@intel.com> wrote:
>
> AVX512 lookup function requires CPU to support RTE_CPUFLAG_AVX512DQ and
> RTE_CPUFLAG_AVX512BW. Add runtime checks of these two flags when deciding
> if vector function can be used.
>
Fixes: 1e5630e40d95 ("fib6: add AVX512 lookup")
> Cc: stable@dpdk.org
>
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
I wish we had a build check for those.
Or maybe a tool/script that would look at libraries/drivers, catch
_mmXXXXX intrinsics and warn if such a library/driver has no call to
corresponding runtime check.
That would save us from having to go to
https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html
...
Could someone from Intel work on this?
In any case, adjusted indent, fixed Fixes: tag, removed superfluous
parenthesis, and applied, thanks.
--
David Marchand
prev parent reply other threads:[~2024-10-11 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 17:31 Vladimir Medvedkin
2024-10-11 9:29 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wxvvam2QyTWLfcZo-SfVGjQ_r0oqdzaOCsYHyMvO5w8Q@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).