From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9691045B13 for ; Fri, 11 Oct 2024 11:30:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EB77402EE; Fri, 11 Oct 2024 11:30:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A528A402E3 for ; Fri, 11 Oct 2024 11:30:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728639003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZMvyvQyvv5ffE9LjKcTxD6b62UlweJU1NkIu+ppfBsM=; b=YugEvjZeBZTrBNDByVwGaTMrtfggtqIXNiebsiJlEW7pSH1FnMh5MGudA/AMSgT+ZzAseB IXXsbbCmysEJqTz+e4QUuqDw/13brjrgZXICN/lvq1fRoBvBZUdFRqxDfLz2twjPF4Og+H ewMn3SIuJwIvefB4MPalonkVwIJj/YU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-sZNZsbw2OW-Z42zsMxKNBQ-1; Fri, 11 Oct 2024 05:29:59 -0400 X-MC-Unique: sZNZsbw2OW-Z42zsMxKNBQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5399a4f3a48so2167513e87.0 for ; Fri, 11 Oct 2024 02:29:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728638998; x=1729243798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZMvyvQyvv5ffE9LjKcTxD6b62UlweJU1NkIu+ppfBsM=; b=Vg0rKAX7KiYODRcrMwNImNj5q6Q3iN9s/q6lO3KBJrk5lveTniQxkE3Foajfs+Ym2E 4rQFbolBJIEBvbJbavSzKmVlB6DCuyOh/+C2KpwbFbP9U0H0yGzscuhWYdbrNyL8TJLl GM0gutOAELCClLV+VsXkg8ebzxt5V041IZIbQC6zZYLaofOxTGL2IlMsiz2NiKLshHPu HAaGJ0uHSsAp7PqdQ1o2u1coLdcSMLc7rEmseR/TQanXudS4Ys+BD1ojJBksk9SLwqew QxaRb1w6exeX0ZDC9brhmiLSDdWx0ccLZzmbEhJdYmnypUdFFeMme35BctCkf7DC12N8 qhXA== X-Forwarded-Encrypted: i=1; AJvYcCV6iOEpAT+eEWVNXiZ6eqzd2xELu7VNRw2fVjUdQGZneCJ7xGky5WqU8/52dO7CaDKHLhpAans=@dpdk.org X-Gm-Message-State: AOJu0YwDlR8XeKZgan6KwDakuFpK1zAJ4D/NiiBOk7MvvvfAGZj7gh1Y Ir74Ty0tWlcuedDGedqnyM7LL5pK3tfCx7fvBXR0oKmBXneVDEkTL3WlLtfK+bncwGPa3ljfvho 9REO6dn5HLMi9GRdBYOYKmw1ZJbcAWDYrlH42EyTkToxYBnTK6ZxRDcQIfKFkVnZlBOdF95gqt8 3tGnnSLAT0X5XIU9k4q1A= X-Received: by 2002:a05:6512:1587:b0:539:8876:5555 with SMTP id 2adb3069b0e04-539da4cd035mr1077437e87.29.1728638998283; Fri, 11 Oct 2024 02:29:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJn0Vujb8wlGtpWMGRxaUZJiQCYtHIkLJSy4rp68NnaC9c+gGvTJuW63N+KPZZBsq7Sbve4EO5d3xsIjoVuKs= X-Received: by 2002:a05:6512:1587:b0:539:8876:5555 with SMTP id 2adb3069b0e04-539da4cd035mr1077422e87.29.1728638997878; Fri, 11 Oct 2024 02:29:57 -0700 (PDT) MIME-Version: 1.0 References: <20241008173136.441340-1-vladimir.medvedkin@intel.com> In-Reply-To: <20241008173136.441340-1-vladimir.medvedkin@intel.com> From: David Marchand Date: Fri, 11 Oct 2024 11:29:46 +0200 Message-ID: Subject: Re: [PATCH] fib6: add runtime checks for vector lookup To: Vladimir Medvedkin , Bruce Richardson , "Mcnamara, John" Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, Oct 8, 2024 at 7:31=E2=80=AFPM Vladimir Medvedkin wrote: > > AVX512 lookup function requires CPU to support RTE_CPUFLAG_AVX512DQ and > RTE_CPUFLAG_AVX512BW. Add runtime checks of these two flags when deciding > if vector function can be used. > Fixes: 1e5630e40d95 ("fib6: add AVX512 lookup") > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Reviewed-by: David Marchand I wish we had a build check for those. Or maybe a tool/script that would look at libraries/drivers, catch _mmXXXXX intrinsics and warn if such a library/driver has no call to corresponding runtime check. That would save us from having to go to https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html ... Could someone from Intel work on this? In any case, adjusted indent, fixed Fixes: tag, removed superfluous parenthesis, and applied, thanks. --=20 David Marchand