From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AB3EBA046B
	for <public@inbox.dpdk.org>; Thu, 25 Jul 2019 21:07:33 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 65BC11C3A8;
	Thu, 25 Jul 2019 21:07:33 +0200 (CEST)
Received: from mail-ua1-f67.google.com (mail-ua1-f67.google.com
 [209.85.222.67]) by dpdk.org (Postfix) with ESMTP id D7EE61C38F
 for <stable@dpdk.org>; Thu, 25 Jul 2019 21:07:28 +0200 (CEST)
Received: by mail-ua1-f67.google.com with SMTP id a97so20256398uaa.9
 for <stable@dpdk.org>; Thu, 25 Jul 2019 12:07:28 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=XVqowcMqz5BWpxyH6Lmdh+n5hvHhgiwboNzV7wW21ZE=;
 b=KSLjJJUzkLf/CMme2Kigr3RKCwbTH9TybccxQt7rKhy7n8FxxfZXpt5gQNG0tLtelg
 g32DBMb/gFAxs3gJPvQPS+yoBMawtKaOyr99gNdjBknaLJfymEpWwevR6wOKRg/ftrYo
 HluHcgJFYlt93P/KwXlnMP+3WHEx1yGSGRz3VfFDPq8amXCpyxrrz3kXrvNcQcBVtxi7
 xD2PjmJPcUHDoJgAsxZ0SUw2r3uHSMMhtcLucm6c3VpdJyXeK6SwWh55EJH3vWtjo5dW
 IS/VtYX6fm2sE+zlH2rIt3nuQfTXPxJWwXsRz9usKI6gb9w802XQU42iEwlIFQBO0iEZ
 CxQw==
X-Gm-Message-State: APjAAAWT0uKUSD1CqHI6OT/sYiSLu05SMh1enU4QclQ0vAf03Eg669Qh
 Z+I0LmsPnQrckq/YtNACSHc5gAdXab+VoietKUMgpw==
X-Google-Smtp-Source: APXvYqw70L771H+pN5MtrwPukN1ocHPlU6YHnnyWHnpzE7elNTbZTW9nPQ4JXGNQF8ka8/FlY3zClKX9g/mDtOusVCw=
X-Received: by 2002:ab0:3003:: with SMTP id f3mr48686741ual.86.1564081648270; 
 Thu, 25 Jul 2019 12:07:28 -0700 (PDT)
MIME-Version: 1.0
References: <1564046068-21905-1-git-send-email-david.marchand@redhat.com>
 <1564046068-21905-6-git-send-email-david.marchand@redhat.com>
 <2cab227c-5e9d-00e1-a6c7-e8f02eb0f6e4@intel.com>
In-Reply-To: <2cab227c-5e9d-00e1-a6c7-e8f02eb0f6e4@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 25 Jul 2019 21:07:17 +0200
Message-ID: <CAJFAV8x2COa9R-yxgCb1o-i+Kv82zBJWhcPyq-Nrp_kO-xpx8w@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>, dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-stable] [PATCH 5/8] net/kni: do not count unsent packets
	as errors
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On Thu, Jul 25, 2019 at 6:12 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 7/25/2019 10:14 AM, David Marchand wrote:
> > err_pkts reflects the number of packets that the driver did not manage to
> > send.
> > This is a temporary situation, those packets are not freed and the
> > application can still retry to send them later.
> > Hence, we can't count them as transmit failed.
>
> 'err_pkts' seems calculated wrong both in Rx & Tx and KNI PMD, looks like we can
> remove it completely, what do you think?

On the rx side, I agree that err_pkts makes little sense.
On the tx side, it can be seen as a "tx full" counter.

So not sure about the tx side, but I sure can remove the rx part (in a
separate patch?).


-- 
David Marchand