From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-vk1-f169.google.com (mail-vk1-f169.google.com
 [209.85.221.169]) by dpdk.org (Postfix) with ESMTP id EC5C51B20A
 for <stable@dpdk.org>; Mon, 14 Jan 2019 15:39:57 +0100 (CET)
Received: by mail-vk1-f169.google.com with SMTP id n126so4883199vke.12
 for <stable@dpdk.org>; Mon, 14 Jan 2019 06:39:57 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=LbwNZcbIAQ8GWPj2mrmh10f6tE+xXC/QGGN0P9uAMtQ=;
 b=NM+pvfsqjIJDI3kpQL2qaaEkHf0jpLSPJNi3ZP0DL+Uz9NqGaChu4y0nmGiuI3oAlm
 gbrx+X560IJ3Qk78/UdkooYsJ2RSQsZYezG6dO8GTxobKteLCp5uQdWE6TXQLlOUsce3
 8mSj6/p8aKcXEvhpJyInzNtB1fAl08otw7HZg1kzPlfGBUBv8Es0VjDM6OOrM0ECNLGW
 H7i2L8em6x3h1Tf6ZKr3AtCbkagna+eElJrkWY34yCWDUdT9a10qJUH3rDh4RCSQhLzs
 eE7+oQ55bYnVyWWGGkW+9l7A1ZbdoA+VsecrhRhGaMB89XH432NdjgtaImxT3n/oFO9H
 ZFvQ==
X-Gm-Message-State: AJcUukeRFBQxW8Xfjb6w76nPpzx6hK10LZ7wq1PC5Xpz3iEyCz5jaLW1
 d5WpvOfsv3+jF/9rgZnzfLbNyKIonzySMQHLBwJqfQ==
X-Google-Smtp-Source: ALg8bN6RveiyBDx4XGxXUfBwl1q9CnRadTehp4XBP4+lvADQDSDsTTH+plh+Y6DFCN88uiEpTfuj3DpzcOavTQUPF/E=
X-Received: by 2002:a1f:b58d:: with SMTP id e135mr9761179vkf.86.1547476797256; 
 Mon, 14 Jan 2019 06:39:57 -0800 (PST)
MIME-Version: 1.0
References: <1547216106-13680-1-git-send-email-hari.kumarx.vemula@intel.com>
 <1547461730-3208-1-git-send-email-hari.kumarx.vemula@intel.com>
In-Reply-To: <1547461730-3208-1-git-send-email-hari.kumarx.vemula@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 14 Jan 2019 15:39:46 +0100
Message-ID: <CAJFAV8x4kJAEnVT6XZpRd8Qqs2LwAWfHMVJ8iB2qZ+NQ=YQROw@mail.gmail.com>
To: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
Cc: dev@dpdk.org, reshma.pattan@intel.com, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-stable] [PATCH v5] eal: fix core number validation
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jan 2019 14:39:58 -0000

On Mon, Jan 14, 2019 at 11:31 AM Hari Kumar Vemula <
hari.kumarx.vemula@intel.com> wrote:

> diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c
> index 2acab9d69..4dc22ec36 100644
> --- a/test/test/test_eal_flags.c
> +++ b/test/test/test_eal_flags.c
> @@ -18,6 +18,7 @@
>  #include <sys/file.h>
>  #include <limits.h>
>
> +#include <rte_per_lcore.h>
>  #include <rte_debug.h>
>  #include <rte_string_fns.h>
>
> @@ -513,6 +514,16 @@ test_missing_c_flag(void)
>         const char *argv25[] = { prgname, prefix, mp_flag,
>                                  "-n", "3", "--lcores",
>                                  "0-1,2@(5-7),(3-5)@(0,2),(0,6),7"};
> +       /* core number is negative value */
> +       const char * const argv26[] = { prgname, prefix, mp_flag,
> +                               "-n", "3", "-l", "-5" };
> +       const char * const argv27[] = { prgname, prefix, mp_flag,
> +                               "-n", "3", "-l", "-5-7" };
> +       /* core number is maximum value */
> +       const char * const argv28[] = { prgname, prefix, mp_flag,
> +                               "-n", "3", "-l", RTE_STR(RTE_MAX_LCORE) };
> +       const char * const argv29[] = { prgname, prefix, mp_flag,
> +                               "-n", "3", "-l",
> "1-"RTE_STR(RTE_MAX_LCORE) };
>

Please move this block with the other "-l" options.
You can add my Reviewed-by tag with this.


Thanks.

-- 
David Marchand