From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC658458CD for ; Mon, 2 Sep 2024 10:23:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0DAB4026F; Mon, 2 Sep 2024 10:23:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 05540400EF for ; Mon, 2 Sep 2024 10:23:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725265426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9IqetXwmTJmLZ9zLwvi9iKLUtNu83b4E1HiNWFXdQNc=; b=CN+cGugmUe10Sn6e8qI6Rol38TTEBx6fdB9mAERoGEkIQMQxrW527iID8F8yhVlY1G6/nX NKFuqdOdmFq1kF8KO//My0CQuI1x41l5kZ/0/3aM+pADTrcRHWnUMjBw7BCKFJt4W0wRZy hWqz1gbk5mtvzDws54hbBl2v1oDrP+c= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-uYV_KHqNO1GvZVaIakBurg-1; Mon, 02 Sep 2024 04:23:45 -0400 X-MC-Unique: uYV_KHqNO1GvZVaIakBurg-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2f3f1bbe2e2so35924341fa.0 for ; Mon, 02 Sep 2024 01:23:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725265424; x=1725870224; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9IqetXwmTJmLZ9zLwvi9iKLUtNu83b4E1HiNWFXdQNc=; b=JmqrnPI7ipg59sSvjSJyTXoqm8zBUsw0SLY/BOR6okaRff1IdjgsYa+fS4FZ+gsHSp DVSh9VtDkS+Rg+Cev9MDbkS9wos4D3w7TgeWDXuT4pzIYJ4saWLJ0aVq1Nu+ivbTtn0b wX6egzDEk23mwsfknJZ5COF/IaVXRz4bBNWLZoXA/hfYq21rOUazTNAzjyStQylF4wnz c45Yg/7aqMWNML+XQHCewsaCmaq+XaYGjcHvNTxEpCzPHn+zUeXwUi5Pfvpq6a0YzLp8 pSKR719x7zln/iXmG81TzqQ4xMUA/j0oFSP9ytQUe2gFGf3NoRhpDakLiza8nTihga3p koiA== X-Forwarded-Encrypted: i=1; AJvYcCXFtfxZ+gRLkatpELErwBHbxav28uFuxgh+FICUlypdu4rDDinEHcKQZ59sW+/ULtysLnQVY58=@dpdk.org X-Gm-Message-State: AOJu0Yyouoxxe1LARM9b4Me+BD3tPRT7z309IDSqxbYDPy35DcuwL2yX qNVOIC+kfcO3MNpo8aDQ2n5JfNpbXV2I+WRtWAa8Kp4Skg0aoxzaP3jGVa4bMvhsriXeuksBmN8 mFNYNlnPNqaOpmlBhmG9E0WeOAGoCZbEGH/OrfCn1llLFirUVhmv4aZtXrwUL00YlQvVtrN+jzv 7thN/Vt453UOojAzgB18E= X-Received: by 2002:a2e:a989:0:b0:2ef:232c:6938 with SMTP id 38308e7fff4ca-2f61e025793mr63921581fa.6.1725265423775; Mon, 02 Sep 2024 01:23:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsiG8n9K3Dn32Ej0xsZnY22OKxmZ/oY93thap+Fhl4hbhz+VGpHcHznH0sckoHpzAYpWHRsOTjpG+kbvQm5eo= X-Received: by 2002:a2e:a989:0:b0:2ef:232c:6938 with SMTP id 38308e7fff4ca-2f61e025793mr63920821fa.6.1725265423146; Mon, 02 Sep 2024 01:23:43 -0700 (PDT) MIME-Version: 1.0 References: <20240829102156.1789758-1-ktraynor@redhat.com> <20240831094206.680e50c9@hermes.local> In-Reply-To: <20240831094206.680e50c9@hermes.local> From: David Marchand Date: Mon, 2 Sep 2024 10:23:31 +0200 Message-ID: Subject: Re: please help backporting some patches to stable release 21.11.8 To: Stephen Hemminger Cc: Kevin Traynor , dpdk stable , Abhinandan Gujjar , Akhil Goyal , Ali Alnubani , Amit Prakash Shukla , Anatoly Burakov , Anoob Joseph , Ashwin Sekhar T K , Bing Zhao , Bruce Richardson , Chengwen Feng , Ciara Loftus , Ciara Power , Conor Walsh , Dariusz Sosnowski , Dengdui Huang , Fabio Pricoco , Ferruh Yigit , Frank Du , Gagandeep Singh , Ganapati Kundapura , Gaoxiang Liu , Gowrishankar Muthukrishnan , Gregory Etelson , Hanumanth Pothula , Harman Kalra , Hemant Agrawal , Honnappa Nagarahalli , Ian Stokes , Jack Bond-Preston , Jerin Jacob , Jiawen Wu , Jiayu Hu , Kai Ji , Kaiwen Deng , Kiran Kumar K , Konstantin Ananyev , Kumara Parameshwaran , Luca Boccassi , =?UTF-8?Q?M=C3=A1rio_Kuka?= , Matan Azrad , Michael Baum , Mingjin Ye , Mohammad Iqbal Ahmad , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Nathan Brown , Nithin Dabilpuram , Ola Liljedahl , Olivier Matz , Ori Kam , Pavan Nikhilesh , Qi Zhang , Rahul Bhansali , Robin Jarry , Rohit Raj , Ruifeng Wang , Selwin Sebastian , Shijith Thotton , Shun Hao , Shuo Li , Srujana Challa , Steve Yang , Suanming Mou , Sunil Kumar Kori , Tomasz Wakula , Tyler Retzlaff , Vamsi Attunuru , Vanshika Shukla , Venkat Kumar Ande , Viacheslav Ovsiienko , Wathsala Vithanage , Wenwu Ma , Yingming Mao X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello, On Sat, Aug 31, 2024 at 6:42=E2=80=AFPM Stephen Hemminger wrote: > > If I build 21.11 with current Gcc there are lot of warnings. > > > ~/DPDK/21.11 $ ninja -C build > ninja: Entering directory `build' > [162/2951] Compiling C object lib/librte_hash.a.p/hash_rte_thash.c.o > In file included from /usr/lib/gcc/x86_64-linux-gnu/14/include/immintrin.= h:77, > from /usr/lib/gcc/x86_64-linux-gnu/14/include/x86intrin.= h:32, > from ../lib/eal/x86/include/rte_vect.h:31, > from ../lib/eal/x86/include/rte_memcpy.h:17, > from ../lib/mempool/rte_mempool.h:50, > from ../lib/mbuf/rte_mbuf.h:38, > from ../lib/net/rte_ip.h:32, > from ../lib/hash/rte_thash.h:25, > from ../lib/hash/rte_thash.c:7: > In function =E2=80=98_mm512_mask_permutexvar_epi8=E2=80=99, > inlined from =E2=80=98__rte_thash_gfni=E2=80=99 at ../lib/hash/rte_th= ash_x86_gfni.h:141:17, > inlined from =E2=80=98rte_thash_gfni=E2=80=99 at ../lib/hash/rte_thas= h_x86_gfni.h:181:20, > inlined from =E2=80=98rte_thash_adjust_tuple=E2=80=99 at ../lib/hash/= rte_thash.c:785:11: > /usr/lib/gcc/x86_64-linux-gnu/14/include/avx512vbmiintrin.h:97:20: warnin= g: =E2=80=98tuple_bytes=E2=80=99 may be used uninitialized [-Wmaybe-uniniti= alized] > 97 | return (__m512i) __builtin_ia32_permvarqi512_mask ((__v64qi) __= B, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~ > 98 | (__v64qi) __= A, > | ~~~~~~~~~~~~= ~~ > 99 | (__v64qi) __= W, > | ~~~~~~~~~~~~= ~~ > 100 | (__mmask64) = __M); > | ~~~~~~~~~~~~= ~~~~ > In file included from ../lib/hash/rte_thash_gfni.h:16, > from ../lib/hash/rte_thash.h:27: > ../lib/hash/rte_thash_x86_gfni.h: In function =E2=80=98rte_thash_adjust_t= uple=E2=80=99: > ../lib/hash/rte_thash_x86_gfni.h:90:33: note: =E2=80=98tuple_bytes=E2=80= =99 was declared here > 90 | __m512i vals, matrixes, tuple_bytes, tuple_bytes_2; > | ^~~~~~~~~~~ > In function =E2=80=98_mm512_mask_permutexvar_epi8=E2=80=99, > inlined from =E2=80=98__rte_thash_gfni=E2=80=99 at ../lib/hash/rte_th= ash_x86_gfni.h:141:17, > inlined from =E2=80=98rte_thash_gfni=E2=80=99 at ../lib/hash/rte_thas= h_x86_gfni.h:181:20, > inlined from =E2=80=98rte_thash_adjust_tuple=E2=80=99 at ../lib/hash/= rte_thash.c:785:11: > /usr/lib/gcc/x86_64-linux-gnu/14/include/avx512vbmiintrin.h:97:20: warnin= g: =E2=80=98permute_mask=E2=80=99 may be used uninitialized [-Wmaybe-uninit= ialized] > 97 | return (__m512i) __builtin_ia32_permvarqi512_mask ((__v64qi) __= B, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~ > 98 | (__v64qi) __= A, > | ~~~~~~~~~~~~= ~~ > 99 | (__v64qi) __= W, > | ~~~~~~~~~~~~= ~~ > 100 | (__mmask64) = __M); > | ~~~~~~~~~~~~= ~~~~ > ../lib/hash/rte_thash_x86_gfni.h: In function =E2=80=98rte_thash_adjust_t= uple=E2=80=99: > ../lib/hash/rte_thash_x86_gfni.h:91:30: note: =E2=80=98permute_mask=E2=80= =99 was declared here > 91 | __mmask64 load_mask, permute_mask, permute_mask_2; > | ^~~~~~~~~~~~ Those above should be fixed in v21.11.4 with 47951ef1dc21 ("hash: fix GFNI implementation build with GCC 12"). I quickly checked other warnings and I see issues already fixed in dpdk-stable/21.11. Please test with latest HEAD of the 21.11 branch. --=20 David Marchand