From: David Marchand <david.marchand@redhat.com>
To: Thanushree Sreerama <thanushree.sreerama@nokia.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [PATCH] pci: pci_vfio: Retry vfio setup device reset, if device is busy
Date: Thu, 4 Sep 2025 09:22:41 +0200 [thread overview]
Message-ID: <CAJFAV8xGTw2ibWBjB7CgAL_Vyk4EHKa19NbbRZBLriF6s1=Yhg@mail.gmail.com> (raw)
In-Reply-To: <20250903111723.5111-1-thanushree.sreerama@nokia.com>
Hello,
Please have a look at
https://doc.dpdk.org/guides/contributing/patches.html before sending a
new revision.
On Wed, 3 Sept 2025 at 16:24, Thanushree Sreerama
<thanushree.sreerama@nokia.com> wrote:
>
> From: "Thanushree.Sreerama" <thanushree.sreerama@nokia.com>
>
> Add proper EAGAIN handling for the device setup by retrying the device reset
>
> Issue:
> asc-0a Disp_0[18237]: EAL: Unable to reset device! Error: 11 (Resource temporarily unavailable)
> asc-0a Disp_0[18237]: EAL: 0000:f4:02.3 setup device failed
> asc-0a Disp_0[18237]: EAL: Requested device 0000:f4:02.3 cannot be used
We are missing the conditions where such an error is hit (iow, why do
we get a EBUSY here).
Please describe the functionnal impact.
Please explain how those timeout/retry values were chosen and how they
are enough for the issue you faced.
>
> Caused due to:
> 92d847a35e1 ("Revert "driver core: Fix uevent_show() vs driver detach race"")
This sha1 does not belong to DPDK public repo.
I also see the patch could not be applied in the CI, so you'll have to
make sure this patch is rebased on main.
> Cc: stable@dpdk.org
If you want this fix to be backported, point at the commit where the
issue was introduced with a Fixes:.
> Change-Id: Ic3ae8701fccdbf1e8e2a575d48e707b4c58e939a
Please remove this marker, this does not make sense for upstream contributions.
> Signed-off-by: Thanushree Sreerama <thanushree.sreerama@nokia.com>
And please register to the mailing list, otherwise your patch waits in
the moderation queue until some dpdk admin looks at it.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2025-09-04 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 11:17 Thanushree Sreerama
2025-09-03 14:16 ` Burakov, Anatoly
2025-09-04 7:22 ` David Marchand [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-09-03 11:15 Thanushree Sreerama
2025-09-03 11:11 Thanushree Sreerama
2025-08-20 14:00 Thanushree Sreerama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xGTw2ibWBjB7CgAL_Vyk4EHKa19NbbRZBLriF6s1=Yhg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thanushree.sreerama@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).