From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83FC746E62 for ; Thu, 4 Sep 2025 09:22:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E3274027D; Thu, 4 Sep 2025 09:22:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 091094027D for ; Thu, 4 Sep 2025 09:22:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756970577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Tds1zfvY3WHvvCxtnWG3Z98K7XhGLFF6rI6J1IEhGs0=; b=WjxjPFleE+ITaejC4ZF8vwET+ZDqissLhLxgbmZQvZ8R1q2VzLiFH99tX2/JgtcwaZHmGg MLGTcelbvKXXRsWMYNAeqVT8uTpWaXdKD+dymvdS9UH+CJZXwHJHOs9mUk94VBKnv92yY6 n3JuGmA4gEMrp8FiN07j7vQZcMJnLGk= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-EirtE_JQM9WIAVOvx15bHw-1; Thu, 04 Sep 2025 03:22:56 -0400 X-MC-Unique: EirtE_JQM9WIAVOvx15bHw-1 X-Mimecast-MFC-AGG-ID: EirtE_JQM9WIAVOvx15bHw_1756970575 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-55f6a61e237so372284e87.0 for ; Thu, 04 Sep 2025 00:22:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756970574; x=1757575374; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Tds1zfvY3WHvvCxtnWG3Z98K7XhGLFF6rI6J1IEhGs0=; b=AegKnes5MwLozMhgqLO8sH0berY6gpo6OANsFvBnAVLdXgu3n3ZrlsODd6z0ruIq66 O5R48KLW3oPfKM8xJOsTENa2bc2OrkHgWCLGPk0VGVcmzmgqvwgLeYnaLwxJL94V23SM g9SaF02EbuUSoZ0UUKVzhfU2wSWRBpc3pRUliGrYrDlF3mS7L/7Ze886htFSKZCtj/Jk lOpgL0hgc+Jt7hR7y2uIrzrGWK4ZOjOSS+tEWwdxsu9qh6Y+ILSZoVcWoyk9UT6eoSn6 4bnFjMWgJqbbeRcX/LRPYcIAt2YSLZ7ouxe3qiesdWiIB4GFN6qEGXurJfLJBRPDot/M 5DqQ== X-Forwarded-Encrypted: i=1; AJvYcCUNP0mXtSP7qWvU51fn3XBrjP5f5nXYSRQclUYkbOKAXk7V3rH2w3+4Kho028kqvh9a4idTajA=@dpdk.org X-Gm-Message-State: AOJu0YyE16B0VT9lQxwuGXCqlsnTOgxZkx1/DCFRoO6n1jGhM5SMIidv ySDcnXXS+Gi57wIS6t+LRp/l+iqtjs3RHbow2BfC9Fd0C1mvLv71T1Y1RlYuUNYlGHszqtIA0wz gyL2eGyS629GFZPYNMLi3OoU6KRW7nvolM/6+qqKWqQ0kx/Q9zoOkDQSYmsLOImd+Svfdcdn4+Y l4N6dy822KNAYarzeLGr+J4lY= X-Gm-Gg: ASbGncvMLbeg3u0am3aRqZWVtTS5wqBIsXG0RHeSy83lIoecKyuZon6yeUCj2FzPn7/ N9juapxgKlMiGFZVmiS765BH6kzI3A4Y2/c7IKqUjAiY2XFnoU8aFuOLk+s2BuSYR4qP4zADQ21 5i+OVMg+ZJlFmdh+wZHp7bB2s= X-Received: by 2002:a05:6512:6398:b0:55f:3b94:2119 with SMTP id 2adb3069b0e04-55f709888d1mr4675620e87.45.1756970574474; Thu, 04 Sep 2025 00:22:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFjBQ70lsjdNx1v/rWKtVEF0CZ0U+l0o4wRen6xfN69pUEpCzd7OqIkD8rI+kYoLgdlISl8ahjEKojryHsFEfs= X-Received: by 2002:a05:6512:6398:b0:55f:3b94:2119 with SMTP id 2adb3069b0e04-55f709888d1mr4675608e87.45.1756970574041; Thu, 04 Sep 2025 00:22:54 -0700 (PDT) MIME-Version: 1.0 References: <20250903111723.5111-1-thanushree.sreerama@nokia.com> In-Reply-To: <20250903111723.5111-1-thanushree.sreerama@nokia.com> From: David Marchand Date: Thu, 4 Sep 2025 09:22:41 +0200 X-Gm-Features: Ac12FXyNJBX5JgFqkBa_4ib9WGks-dbM2lHtpmNHpGy8qP8oRQMasG8S5rPnJuI Message-ID: Subject: Re: [PATCH] pci: pci_vfio: Retry vfio setup device reset, if device is busy To: Thanushree Sreerama Cc: dev@dpdk.org, stable@dpdk.org, Anatoly Burakov X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -hp6Mmseu3fg_kJlufLQkzkO0Rno9IxLMpx4zmbqEkQ_1756970575 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello, Please have a look at https://doc.dpdk.org/guides/contributing/patches.html before sending a new revision. On Wed, 3 Sept 2025 at 16:24, Thanushree Sreerama wrote: > > From: "Thanushree.Sreerama" > > Add proper EAGAIN handling for the device setup by retrying the device reset > > Issue: > asc-0a Disp_0[18237]: EAL: Unable to reset device! Error: 11 (Resource temporarily unavailable) > asc-0a Disp_0[18237]: EAL: 0000:f4:02.3 setup device failed > asc-0a Disp_0[18237]: EAL: Requested device 0000:f4:02.3 cannot be used We are missing the conditions where such an error is hit (iow, why do we get a EBUSY here). Please describe the functionnal impact. Please explain how those timeout/retry values were chosen and how they are enough for the issue you faced. > > Caused due to: > 92d847a35e1 ("Revert "driver core: Fix uevent_show() vs driver detach race"") This sha1 does not belong to DPDK public repo. I also see the patch could not be applied in the CI, so you'll have to make sure this patch is rebased on main. > Cc: stable@dpdk.org If you want this fix to be backported, point at the commit where the issue was introduced with a Fixes:. > Change-Id: Ic3ae8701fccdbf1e8e2a575d48e707b4c58e939a Please remove this marker, this does not make sense for upstream contributions. > Signed-off-by: Thanushree Sreerama And please register to the mailing list, otherwise your patch waits in the moderation queue until some dpdk admin looks at it. Thanks. -- David Marchand