From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78081A0C55 for ; Thu, 14 Oct 2021 09:04:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 611BD41190; Thu, 14 Oct 2021 09:04:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 28DDE40042 for ; Thu, 14 Oct 2021 09:04:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634195072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0N7aPpYnZMbBLRyUTmiHlcIlKk+RF8K7ZrlM8eQqPhY=; b=XmXGE2ZRF+Fk/h4IQPPK1ouQFYpVYRBKZzjIfv414tAkUtNcOhVL6p/VX7xYUeHsLJN+Cl Apc5e4AxkYPZyFO5Kx0EULtKxXHXUnOGCl4TdJyg+B5zUv+Vujn8o58mDS6vkChistUmZO KiYi50DxiMluh8CD5tDvldCqZjHmi7g= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-M3EwhCvmP0ufcptvW4xmiA-1; Thu, 14 Oct 2021 03:04:31 -0400 X-MC-Unique: M3EwhCvmP0ufcptvW4xmiA-1 Received: by mail-lf1-f70.google.com with SMTP id br42-20020a056512402a00b003fd94a74905so3716186lfb.7 for ; Thu, 14 Oct 2021 00:04:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0N7aPpYnZMbBLRyUTmiHlcIlKk+RF8K7ZrlM8eQqPhY=; b=hMDHCOOTFR14SUoqpBJ0RgWhXfDuGr5wbjUDb8gk+5wXtxJ0WrDCS3GwdAIobMuYAr OWoz+XLWKrSYg3+vDFLTtL+xqhaZ2jR7mj7//iINh2/YY1FpAgBqtwaIczhNzy15DDRm KqySPU8AVAMAX3rKoGDHmMmLGf/6UdOADm9HnMDKAiNSA2FhBZxqbDL2WUTWrW1hLOy6 46rfMW6ByBT1umEWoO+U+0RApp+nggG9HvXnMsGnvrwiNNJTeHADLv2FQML5sJr6EYR8 FuZs5IKThHhzaIXzf5PSrs5X5/bHFCBmnOrg7eEKuq/NDHETpSJy/XS2Tz4bR+50ONbF zfWg== X-Gm-Message-State: AOAM531PyEzUYsumFGbWQ3kBdrZW41nskMP03ILW3ts4HOWCueJ49J9A 4hLkwToin74aGdx0GEqHQAiX9kuyhQrTQYdtD5NCwbhRoqLx7EVXKzafD1uI2puMsGV8ztlYdgi +9PZRieipJXkQniEflhOSW9g= X-Received: by 2002:a2e:9588:: with SMTP id w8mr4215319ljh.81.1634195069871; Thu, 14 Oct 2021 00:04:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJztIoKABUIjOMzYRfcwGaN63TO23npfocL03f7rYmyjqDpORy5WcKVeLaPK6VcLznmR3CqJU6gjTbCHTebSydc= X-Received: by 2002:a2e:9588:: with SMTP id w8mr4215297ljh.81.1634195069652; Thu, 14 Oct 2021 00:04:29 -0700 (PDT) MIME-Version: 1.0 References: <1633728526-197782-1-git-send-email-vladimir.medvedkin@intel.com> <47f6bf7f-259f-f376-3e23-a2b0c7b886b7@intel.com> In-Reply-To: <47f6bf7f-259f-f376-3e23-a2b0c7b886b7@intel.com> From: David Marchand Date: Thu, 14 Oct 2021 09:04:18 +0200 Message-ID: To: "Medvedkin, Vladimir" Cc: dev , "Wang, Yipeng1" , "Gobriel, Sameh" , Bruce Richardson , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] test/hash: fix buffer overflow X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hello Vladimir, On Wed, Oct 13, 2021 at 9:27 PM Medvedkin, Vladimir wrote: > > With patch applied, ASan reports another issue. > > Did you test your fix with ASan? > > > > You're right, for some reason ASAN wasn't enabled. > I applied patch and built running .ci/linux-build.sh, > also I build with CFLAGS + LDFLAGS. > > Bruce suggested to use meson options instead of using CFLAGS, so > meson configure build -Db_sanitize=address -Db_lundef=false > works fine. Well, yes, you can directly do this. I linked to my GHA patch in the bz, because I find it easier and reproducible to push fixes in GHA and get the result: no question about "did I enable ASan?" or "did I start the test correctly?". FYI, b_lundef seems necessary only with clang, gcc should be fine without it. IIUC, those compilers went with different choices on how to pull libasan (clang went with static, gcc went with shared). Hopefully, we will have something easier to use in DPDK with Zhihong work. > > I'll sent v2 for this. Thanks, I'll look at it. -- David Marchand