From: David Marchand <david.marchand@redhat.com>
To: Aaron Conole <aconole@redhat.com>
Cc: dev <dev@dpdk.org>, Michael Santana <msantana@redhat.com>,
dpdk stable <stable@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests
Date: Fri, 2 Aug 2019 15:45:22 +0200 [thread overview]
Message-ID: <CAJFAV8xSd8__-SzS3GEu6k73eOPqrWoaSnm=-wkS+hsBGm00VQ@mail.gmail.com> (raw)
In-Reply-To: <f7t5znf7knt.fsf@dhcp-25.97.bos.redhat.com>
On Fri, Aug 2, 2019 at 3:37 PM Aaron Conole <aconole@redhat.com> wrote:
>
> David Marchand <david.marchand@redhat.com> writes:
>
> > On Thu, Aug 1, 2019 at 2:28 PM David Marchand <david.marchand@redhat.com> wrote:
> >>
> >> The memory tests currently check that, for normal mode (not legacy mode),
> >> there is no memory left behind when exiting.
> >>
> >> The problem is that if a ethdev port is allocated when scanning pci
> >> devices (even if the driver probe fails like when you have a virtio
> >> management interface attached to the kernel), on exit, dpdk won't free
> >> the associated memory since ethdev never frees the ethdev memzone.
> >>
> >> Workaround this by disabling pci scan.
> >
> > Not entirely happy with this patch.
> > I am open to suggestions :-)
>
> Seems like an order of allocation / free issue. Is it possible to
> change the order to be consistent? IE: we only allocate something after
> we know there's good reason to do so and then we can be sure to always
> free? I don't know the code in this area well enough yet to comment any
> more than that.
Err, this looks hard to achieve.
The test is quite basic, in that it expects all hugepage files to be
removed on dpdk exit (meaning all allocations freed).
--
David Marchand
next prev parent reply other threads:[~2019-08-02 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 12:27 David Marchand
2019-08-01 12:29 ` David Marchand
2019-08-02 11:13 ` David Marchand
2019-08-02 13:37 ` Aaron Conole
2019-08-02 13:45 ` David Marchand [this message]
2019-08-02 20:57 ` Thomas Monjalon
2019-08-03 9:51 ` David Marchand
2019-08-05 10:19 ` Thomas Monjalon
2019-08-08 11:23 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xSd8__-SzS3GEu6k73eOPqrWoaSnm=-wkS+hsBGm00VQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=msantana@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).