From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A243A10DA for ; Fri, 2 Aug 2019 15:45:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1136D1C2B8; Fri, 2 Aug 2019 15:45:37 +0200 (CEST) Received: from mail-vk1-f196.google.com (mail-vk1-f196.google.com [209.85.221.196]) by dpdk.org (Postfix) with ESMTP id 6C7131C2B0 for ; Fri, 2 Aug 2019 15:45:34 +0200 (CEST) Received: by mail-vk1-f196.google.com with SMTP id y130so15394421vkc.0 for ; Fri, 02 Aug 2019 06:45:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wdCLxTAfaoOO7vQzSsWy6heuphbsfurd8RrlVVtoL3k=; b=iqVRuC/ipP0Q+oo54sLAS6p+8WQW6Ij8zpY7+9DUsvyC400z5Bjzy5GiQEm/jK6CjJ t7LbAfvUhyG4NpUf9bkEUbWfUNwv5RLVjuH8d+bOq7udcSlMJSj5ChE4PFcZJSRGSDbJ 35GW2AXx1kIV16ahe6m/eOhxbfhWRl8DO33kvFsvcx24JdsAaO94oBs8jAGz6AwY8HfW 8A4ohHnhTE30DHufSXIsA304GB6ciKTuiiEQwbbvExt71OcOhrVCeR5gdVvJZxRAQcOo 1sX3cpIxoKU34gGsb0w9DgNvK1igTdk7McLF19q+6dEi+BXW++EcjNr0GCR/7Jlo37S0 J7Hw== X-Gm-Message-State: APjAAAVssTosQzrRHDFNW0YdCgiZtXezsVVnPmGN7eCCohvub0iYwD8z N4VqH9Ynfnr5opIfyyzmqD1eq0NiAzBlZtMgtJQ9zA== X-Google-Smtp-Source: APXvYqwtNFC7swX/ecb5la+ec6FPJioAFG9AJwKr/uRJMfx9JrncOBoaNmllOaRXM+8jsSx4oHxDlj4ehhMTsUfWDXU= X-Received: by 2002:a1f:50c1:: with SMTP id e184mr53672836vkb.86.1564753533742; Fri, 02 Aug 2019 06:45:33 -0700 (PDT) MIME-Version: 1.0 References: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 2 Aug 2019 15:45:22 +0200 Message-ID: To: Aaron Conole Cc: dev , Michael Santana , dpdk stable , "Burakov, Anatoly" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, Aug 2, 2019 at 3:37 PM Aaron Conole wrote: > > David Marchand writes: > > > On Thu, Aug 1, 2019 at 2:28 PM David Marchand wrote: > >> > >> The memory tests currently check that, for normal mode (not legacy mode), > >> there is no memory left behind when exiting. > >> > >> The problem is that if a ethdev port is allocated when scanning pci > >> devices (even if the driver probe fails like when you have a virtio > >> management interface attached to the kernel), on exit, dpdk won't free > >> the associated memory since ethdev never frees the ethdev memzone. > >> > >> Workaround this by disabling pci scan. > > > > Not entirely happy with this patch. > > I am open to suggestions :-) > > Seems like an order of allocation / free issue. Is it possible to > change the order to be consistent? IE: we only allocate something after > we know there's good reason to do so and then we can be sure to always > free? I don't know the code in this area well enough yet to comment any > more than that. Err, this looks hard to achieve. The test is quite basic, in that it expects all hugepage files to be removed on dpdk exit (meaning all allocations freed). -- David Marchand