From: David Marchand <david.marchand@redhat.com>
To: "Xueming(Steven) Li" <xuemingl@mellanox.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
Asaf Penso <asafp@mellanox.com>, dev <dev@dpdk.org>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size
Date: Wed, 20 Nov 2019 14:25:09 +0100 [thread overview]
Message-ID: <CAJFAV8xX1M=TmUEVnSUAGj_VuAP9TYu3iQCELOjae0a9ELYDtA@mail.gmail.com> (raw)
In-Reply-To: <DB6PR05MB3190CF0963833ECFF7069D02AC4F0@DB6PR05MB3190.eurprd05.prod.outlook.com>
On Wed, Nov 20, 2019 at 3:12 AM Xueming(Steven) Li
<xuemingl@mellanox.com> wrote:
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Wednesday, November 20, 2019 4:47 AM
> > To: Xueming(Steven) Li <xuemingl@mellanox.com>; Anatoly Burakov
> > <anatoly.burakov@intel.com>
> > Cc: Asaf Penso <asafp@mellanox.com>; dev <dev@dpdk.org>; dpdk stable
> > <stable@dpdk.org>
> > Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element
> > size
> >
> > On Tue, Nov 12, 2019 at 3:50 PM Xueming Li <xuemingl@mellanox.com>
> > wrote:
> > >
> > > When resize a memory with next element, the original element size grows.
> > > If the orginal element has padding, the real inner element size didn't
> > > grow as well and this causes trailer verification failure when malloc
> > > debug enabled.
> >
> > I did not see this when running the malloc_autotest with debug enabled.
> > What is missing for me to catch it?
> >
> Yes, it happens rarely, depends on memory fragment. I only caught this in middle of a long test.
>
> >
> > Just a bit chilly to apply this series.
> > The first patch seems an optimisation.
> > The second one seems more interesting if we fix the debug mode, but I
> > suppose we can live without them in 19.11.
> Few people enable memory debug option, they are there for years.
Had a discussion offlist with Anatoly.
Those two issues are hard to catch but the fixes are relevant and
Anatoly is confident.
I will take this in rc3.
Series applied, thanks.
--
David Marchand
next prev parent reply other threads:[~2019-11-20 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:50 [dpdk-stable] [PATCH 1/2] malloc: fix realloc wrong copy size Xueming Li
2019-11-12 14:50 ` [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size Xueming Li
2019-11-14 15:11 ` Burakov, Anatoly
2019-11-19 20:47 ` David Marchand
2019-11-20 2:12 ` Xueming(Steven) Li
2019-11-20 13:25 ` David Marchand [this message]
2019-11-21 12:30 ` Burakov, Anatoly
2019-11-21 12:55 ` Xueming(Steven) Li
2019-11-21 13:15 ` Burakov, Anatoly
2019-11-21 13:17 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2019-11-21 14:11 ` Xueming(Steven) Li
2019-11-14 15:11 ` [dpdk-stable] [PATCH 1/2] malloc: fix realloc wrong copy size Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xX1M=TmUEVnSUAGj_VuAP9TYu3iQCELOjae0a9ELYDtA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=asafp@mellanox.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=xuemingl@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).