From: David Marchand <david.marchand@redhat.com>
To: David Hunt <david.hunt@intel.com>
Cc: dev <dev@dpdk.org>, lei.a.yao@intel.com, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] examples/power: fix ack for enable/disable turbo
Date: Thu, 13 Feb 2020 16:25:26 +0100 [thread overview]
Message-ID: <CAJFAV8xXJ2ggqGgZbUGV=HjW4CdkBQqxm+3Tg+6VdHd3Usrt4A@mail.gmail.com> (raw)
In-Reply-To: <20200211105008.4540-1-david.hunt@intel.com>
On Tue, Feb 11, 2020 at 11:50 AM David Hunt <david.hunt@intel.com> wrote:
> When a VM sends a command through virtio-serial to enable/disable
> turbo, it is successfully enabled or disabled, yet the response to the
> VM is NACK. This is because all the library frequency change APIs return
> 1 for success (change in frequency), 0 for success (no change in
> frequency) and -1 for failure. However the turbo enable/disable APIs just
> return 0 for success and -1 for failure.
>
> Fix the handling of the return code to treat ">= 0" as success, and
> send an ACK. Only send NACK when < 0 (failure).
>
> Fixes: 0de94bcac7fc ("examples/vm_power: send confirmation cmd to guest")
Cc: stable@dpdk.org
> Signed-off-by: David Hunt <david.hunt@intel.com>
Acked-by: Lei Yao<lei.a.yao@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-02-13 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 10:50 David Hunt
2020-02-11 23:48 ` Yao, Lei A
2020-02-13 15:25 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xXJ2ggqGgZbUGV=HjW4CdkBQqxm+3Tg+6VdHd3Usrt4A@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=lei.a.yao@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).