From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58ECEA0543 for ; Thu, 13 Feb 2020 16:25:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 36A341C038; Thu, 13 Feb 2020 16:25:46 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id AB2FF1C028 for ; Thu, 13 Feb 2020 16:25:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581607543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A9RP0bZgkYt4Mb7eUnq8PvAn9Po7lm8SeDUGU0Xj5CA=; b=S8TRu5s30pwAVvmvgXiUZrMOwcHorp7eqWBNhov7DPLs2GQv/Xwme2FbY5NvmW6tpIapaW pbJtJbZBtG/5O4Q/31qTRZ3//HQlH36j4JAjrvrJQYpx2axlHJu2hsFcy3I3rZ53/7UjIY e5r8E6zMuYmr3UR/u5sSQgB0lmqUKHM= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-389-qophADWPO5-Er9zbNl1Izg-1; Thu, 13 Feb 2020 10:25:39 -0500 Received: by mail-vk1-f199.google.com with SMTP id x4so2060980vkb.11 for ; Thu, 13 Feb 2020 07:25:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9vDTZw/hHZKJEmYnHIc11dgSr5C5heJQFNbHs1JzoW8=; b=mS4WzIodKJsuTqUWHKSyR+VEeDXU+Ev/22LfjFvKnmoayH7MUh8Q/qSRPOuKDqbt2T IDaKCitoKMO6d7BJWfXtk+OLO0lXm4RS/3UQIPwLQiRsAuyPVKPDznFJKyd8kkQEG7LM 9rJpc57w0K2aBhwrSKElCC4XNK95KWd3/FcSDK4Wo7Vm7evrVH4kdAYH92QBJQINUKrl lPI6quJAn/P4lhJsgR8kqLjSihEooECkOEkqqOIOwOgcCFEHvonou36d5hRhLVRh281p /iwjwsPnorIglGFZqF/K202E+9N1qE9Fnpg++cprcIH6Hdl7jIjnwLkHnlZDqGCSmDSn 2gOQ== X-Gm-Message-State: APjAAAXfDmv+3kmnEBQzMfFHgi9ODmonSgzGkEnTYFYmvz4NADxIwrSc LnxKRLqtsCwDGXrtRKr7GJPfqLSBA4lXsZKOkRr5TP+ARpYnKpylu4HoLAXPcKBh0/Hy8P9r5sJ RVghF2ZFTw+dWWEE74m8g19w= X-Received: by 2002:ab0:618a:: with SMTP id h10mr7808830uan.53.1581607538510; Thu, 13 Feb 2020 07:25:38 -0800 (PST) X-Google-Smtp-Source: APXvYqxZQ96+txh1eHrAhX0fig1TrSnP1RUHlo8/JXXkoOAL94At771W+5FRxc+aNGfzezI/+avbN93sKu838TMSU6c= X-Received: by 2002:ab0:618a:: with SMTP id h10mr7808809uan.53.1581607538170; Thu, 13 Feb 2020 07:25:38 -0800 (PST) MIME-Version: 1.0 References: <20200211105008.4540-1-david.hunt@intel.com> In-Reply-To: <20200211105008.4540-1-david.hunt@intel.com> From: David Marchand Date: Thu, 13 Feb 2020 16:25:26 +0100 Message-ID: To: David Hunt Cc: dev , lei.a.yao@intel.com, dpdk stable X-MC-Unique: qophADWPO5-Er9zbNl1Izg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [PATCH] examples/power: fix ack for enable/disable turbo X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, Feb 11, 2020 at 11:50 AM David Hunt wrote: > When a VM sends a command through virtio-serial to enable/disable > turbo, it is successfully enabled or disabled, yet the response to the > VM is NACK. This is because all the library frequency change APIs return > 1 for success (change in frequency), 0 for success (no change in > frequency) and -1 for failure. However the turbo enable/disable APIs just > return 0 for success and -1 for failure. > > Fix the handling of the return code to treat ">=3D 0" as success, and > send an ACK. Only send NACK when < 0 (failure). > > Fixes: 0de94bcac7fc ("examples/vm_power: send confirmation cmd to guest") Cc: stable@dpdk.org > Signed-off-by: David Hunt Acked-by: Lei Yao Applied, thanks. --=20 David Marchand