From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CCDA43D6B for ; Thu, 28 Mar 2024 12:16:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18000402CE; Thu, 28 Mar 2024 12:16:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BBFFD402AC for ; Thu, 28 Mar 2024 12:16:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711624577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fqmvk2m7FVHF+23VUaxwaSdJlsh0kOqN27OqeBdVDLU=; b=Bz5Vdd6Gyuv/jF6Y+7kptLfx225xmYOS4pGmIIa51MNKPVFdkFb36RSSTLj7Y72D6Tsl8U H7jV+kW4N9OY70U/C2xPilWtMA+T4e9R/LK6SGC2CU171AWCjVbVh4dnRSEYxiWCMSJ3+y DO6IklZy9vs/FSaFaZY47wJjYsiZ0ZE= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-Mt-dXMC6PKW44dYi4s6wdQ-1; Thu, 28 Mar 2024 07:16:15 -0400 X-MC-Unique: Mt-dXMC6PKW44dYi4s6wdQ-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-515c91a7ffdso415440e87.0 for ; Thu, 28 Mar 2024 04:16:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711624574; x=1712229374; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fqmvk2m7FVHF+23VUaxwaSdJlsh0kOqN27OqeBdVDLU=; b=L5ZyvrMuYYfWEe40VMLOuVSSQG94GtVHBzF9HBc4xArEuxfeM9P/UB8H+2vBs2pnQ/ k6ZCnROjo5HQiB8VDolNzmN62+NmzcMW4PhFO/wdc1lfsjPpVL2p4v+Jr/UFz6dfn0xq QmEuvDaIWIxqej6/52MrTxS/NNvT4wP7qx/bo/KIPiIZc1XoU1oo2Sld2SjTRNnIaSrp sJsIF6FWiUBQ7YqfSE5uNuVvNOpr0kDCvaLnvqFMInH5hpYCZuIWrsASgVLOzVE/ro0e tRels+g+39i0OJ5ZFrIlNwG2MdrHM7dBwj3qogaXxd9fTdFuwNIPfhiTp/QxjTLoWVQy 027w== X-Forwarded-Encrypted: i=1; AJvYcCW84XHAZsMq8ODe8mOYdmor2XoJP3MF+A2/uw8HLkWkllFdICDhaq96w4ZIZ0K2zy+DW3z9Kjcu/meCrfhj0Ag= X-Gm-Message-State: AOJu0Yz0r5iQejGM7suFULYA4x+G1kmeYDJ1XKRZJDhWVi7pDW/G5Cob 8bfcQpFrafSIuO9ea9XSoofpSYyFmLdlXGgXIT8map9LD+n7B01uf8K7nBFKqhsrySwoc+oOdo/ Lrpi219BziR2TFqSNk4LZy2ThrRhKQMzdm/6CRX2RMuZLD6lieelHo2Ern68THwixR68ULAKF4d IAy4/QxApSznh7UH6Aqfs= X-Received: by 2002:a05:6512:3133:b0:513:24ba:466a with SMTP id p19-20020a056512313300b0051324ba466amr2074340lfd.53.1711624574278; Thu, 28 Mar 2024 04:16:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+2ifokGvOnOb4Ya04UqUTwjhJQl1q6teOXxFzpEnTZ5S1m+HLMrUEYO73+sTtgC6lsEfCVe3YPSSTLqxBT6o= X-Received: by 2002:a05:6512:3133:b0:513:24ba:466a with SMTP id p19-20020a056512313300b0051324ba466amr2074316lfd.53.1711624573906; Thu, 28 Mar 2024 04:16:13 -0700 (PDT) MIME-Version: 1.0 References: <20240327184413.3192526-1-vladimir.medvedkin@intel.com> In-Reply-To: <20240327184413.3192526-1-vladimir.medvedkin@intel.com> From: David Marchand Date: Thu, 28 Mar 2024 12:16:02 +0100 Message-ID: Subject: Re: [PATCH] net/ice: fix vlan stripping in double VLAN mode To: Vladimir Medvedkin Cc: dev@dpdk.org, carlosmn@weg.net, mingjinx.ye@intel.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Wed, Mar 27, 2024 at 7:44=E2=80=AFPM Vladimir Medvedkin wrote: > > The ICE hardware can operate in two modes - single vlan mode > or double vlan mode. Depending on the operating mode the hardware > handles vlan header with single vlan tag differently. > When double vlan enabled, a packet with a single VLAN is treated > as a packet with outer VLAN only. Otherwise, a single VLAN in a > packet is treated as inner VLAN. > > This patch fixes the logic of how vlan stripping is programmed. > > Bugzilla ID: 1402 Nit: no need for an empty line here, the Bugzilla ID: tag goes with the Fixes: and Cc: block. > > Fixes: de5da9d16430 ("net/ice: support double VLAN") > Cc: mingjinx.ye@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Thanks Vladimir. It looks to fix the issue I observed. I'll let Carlos confirm the fix is good for him too. --=20 David Marchand