From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>,
ivan.malov@oktetlabs.ru,
Andrew Rybchenko <arybchenko@solarflare.com>,
Stephen Hemminger <stephen@networkplumber.org>,
dpdk stable <stable@dpdk.org>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] log: fix level picked with globbing on type register
Date: Thu, 9 Apr 2020 10:26:43 +0200 [thread overview]
Message-ID: <CAJFAV8xcOY-2DcmbdxtZZQ5iQBntpm6y+oi6niyuncM_Za6yyg@mail.gmail.com> (raw)
In-Reply-To: <20200407224758.57459-1-thomas@monjalon.net>
On Wed, Apr 8, 2020 at 12:48 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> When a log type is registered, the level can be picked
> by matching saved options.
> The check of fnmatch globbing result was reversed.
>
> The same bug was already fixed in a similar function.
> This one is acting in log type register function.
>
> Note: this function rte_log_register_type_and_pick_level()
> is not used a lot and could be merged with rte_log_register().
Same fix as a patch I sent quite some time ago and left behind..
https://patchwork.dpdk.org/patch/57742/
I left it in a series I wanted to work on later...
Anyway, this fix is needed.
I suppose we are missing a unit test too.
--
David Marchand
next prev parent reply other threads:[~2020-04-09 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 22:47 [dpdk-stable] " Thomas Monjalon
2020-04-09 8:26 ` David Marchand [this message]
2020-04-16 20:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xcOY-2DcmbdxtZZQ5iQBntpm6y+oi6niyuncM_Za6yyg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).