From: David Marchand <david.marchand@redhat.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Neil Horman <nhorman@tuxdriver.com>, dev <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
dpdk stable <stable@dpdk.org>,
bingz@mellanox.com
Subject: Re: [dpdk-stable] [EXT] Re: [PATCH] devtools: fix check symbol change script
Date: Mon, 23 Mar 2020 10:30:45 +0100 [thread overview]
Message-ID: <CAJFAV8xg9R+jU6hywF4xBqguj3GNgLPAvhFZh9QAxmHa4rTmug@mail.gmail.com> (raw)
In-Reply-To: <20200323092809.GA16547@outlook.office365.com>
On Mon, Mar 23, 2020 at 10:28 AM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
> On Mon, Mar 23, 2020 at 09:13:22AM +0100, David Marchand wrote:
> > ----------------------------------------------------------------------
> > On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram
> > <ndabilpuram@marvell.com> wrote:
> > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> > > index c5434f3..19ce82f 100755
> > > --- a/devtools/check-symbol-change.sh
> > > +++ b/devtools/check-symbol-change.sh
> > > @@ -17,13 +17,13 @@ build_map_changes()
> > > # map files are altered, and all section/symbol names
> > > # appearing between a triggering of this rule and the
> > > # next trigger of this rule are associated with this file
> > > - /[-+] a\/.*\.map/ {map=$2; in_map=1}
> > > + /[-+] [ab]\/.*\.map/ {map=$2; in_map=1}
> > >
> > > # Same pattern as above, only it matches on anything that
> > > # does not end in 'map', indicating we have left the map chunk.
> > > # When we hit this, turn off the in_map variable, which
> > > # supresses the subordonate rules below
> > > - /[-+] a\/.*\.[^map]/ {in_map=0}
> > > + /[-+] [ab]\/.*\.[^map]/ {in_map=0}
> >
> > [^map] does not mean "not word map" but actually "none of the
> > character m, a or p".
> >
> > So potentially, any file extension starting with m, a or p could
> > trigger an issue.
> > For example, a change in .mk files, .py files and
> > ./devtools/check-forbidden-tokens.awk ./devtools/libabigail.abignore
> > could lead to incorrect symbol check.
> >
> > How about the following change:
> >
> > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
> > index c5434f3bb0..ed2178e36e 100755
> > --- a/devtools/check-symbol-change.sh
> > +++ b/devtools/check-symbol-change.sh
> > @@ -17,13 +17,11 @@ build_map_changes()
> > # map files are altered, and all section/symbol names
> > # appearing between a triggering of this rule and the
> > # next trigger of this rule are associated with this file
> > - /[-+] a\/.*\.map/ {map=$2; in_map=1}
> > + /[-+] [ab]\/.*\.map/ {map=$2; in_map=1; next}
> >
> > - # Same pattern as above, only it matches on anything that
> > - # does not end in 'map', indicating we have left the map chunk.
> > - # When we hit this, turn off the in_map variable, which
> > - # supresses the subordonate rules below
> > - /[-+] a\/.*\.[^map]/ {in_map=0}
> > + # The previous rule catches all .map files, anything else
> > + # indicates we left the map chunk.
> > + /[-+] [ab]\// {in_map=0}
> >
> > # Triggering this rule, which starts a line and ends it
> > # with a { identifies a versioned section. The section name is
> >
> >
>
> Agreed. I tested and it works fine for me. I can send a V2 with this change if it is fine.
Sure, thanks!
--
David Marchand
next prev parent reply other threads:[~2020-03-23 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 14:44 [dpdk-stable] " Nithin Dabilpuram
2020-03-19 14:56 ` David Marchand
2020-03-19 15:40 ` Neil Horman
2020-03-19 15:45 ` [dpdk-stable] [EXT] " Nithin Dabilpuram
2020-03-19 18:59 ` Neil Horman
2020-03-19 15:49 ` [dpdk-stable] " Bing Zhao
2020-03-22 14:37 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
2020-03-23 8:13 ` [dpdk-stable] " David Marchand
2020-03-23 9:28 ` [dpdk-stable] [EXT] " Nithin Dabilpuram
2020-03-23 9:30 ` David Marchand [this message]
2020-03-23 11:56 ` [dpdk-stable] [PATCH v2] " Nithin Dabilpuram
2020-03-23 13:19 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xg9R+jU6hywF4xBqguj3GNgLPAvhFZh9QAxmHa4rTmug@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bingz@mellanox.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).